search

nextcloud / passman-webextension

Webextension for the Passman Nextcloud app. Also offers browser extension & Android app.
https://passman.cc
GNU Affero General Public License v3.0
115 stars 43 forks source link

inputs "false" into non-entered fields #203

Open Strubbl opened 6 years ago

Strubbl commented 6 years ago
### Steps to reproduce 1. open a site i never logged in before 2. login 3. accept to save password for future use in popup of passman ### Expected behaviour Password is stored in vault. Field url shall contain the url of the page i logged in to. Field "notes" shall have no content. ### Actual behaviour Password is stored in vault. But field url only has "false" as content. Field notes has "false" as content. ### Configuration **Operating system**: Archlinux **Browser**: Firefox 56 **Extensions that might cause interference**: none **Passman version**: 2.1.4 **Extension version**: 2.0.4 **Nextcloud version**: 12.0.3 #### Browser log
Browser log ``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/51090189-inputs-false-into-non-entered-fields?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github).
brantje commented 6 years ago

Thank you for bringing this to my attention, will try to have a look this weekend.

Strubbl commented 6 years ago

This is not always reproducible. I had this issue with github. With another page it worked and automatically assigned the of that page as label</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/brantje"><img src="https://avatars.githubusercontent.com/u/2758767?v=4" />brantje</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Yea, saw it too during testing, do you have a site where it messes up?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Strubbl"><img src="https://avatars.githubusercontent.com/u/97055?v=4" />Strubbl</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Yes, but only github so far. </p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>