search

nextcloud / passman-webextension

Webextension for the Passman Nextcloud app. Also offers browser extension & Android app.
https://passman.cc
GNU Affero General Public License v3.0
114 stars 43 forks source link

Passwords fields in overlay forms not (always) recognized #226

Open ghost opened 6 years ago

ghost commented 6 years ago
## Bug report ### Steps to reproduce 1. Save password for an overlay login (e.g Paypal.com or cerberusapp.com) 2. Access Site Again 3. Fields not automatically filled, when selecting account from passman search, fields get filled but no update or this url is asked either. ### Expected behaviour Password fields should be recognized in overlay login forms ### Actual behaviour They don't (duh!) ### Configuration **Operating system**: Max OS X 10.10.5 **Browser**: Chome 63.0.3239.108 **Extensions that might cause interference**: non because it doesn't work with or without any **Passman version**: 2.0.4 in chrome and 2.1.4 on server **Operating system**: Again? Max OS X 10.10.5 Or the server nextcloud runs on: Ubuntu 16.04 **Web server:** Apache2 **Database:** holy MariaDB **PHP version:** php 7.1 fpm **cloud server:** Nextcloud or ownCloud Nextcloud **cloud version:** (see admin page or version.php) 12.0.4 #### Browser log
Browser log Login field:
#### Cloud log
Cloud log Not needed because the cloud works fine. It's just the browser extension
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/53195643-passwords-fields-in-overlay-forms-not-always-recognized?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github).
ghost commented 6 years ago

Moved this issue to passman-webextension as requested.

adocampo commented 6 years ago

I reported this behaviour some months ago. Those kind of logons are increasing in popularity, so I cannot use passman on several places, right now I'm here just to point that on forum.xda-developers.com passman even recognizes the login form as a login form, so no icons appears to manually add the site as I can do on others sites, like for example on home.mycroft.ai, where passman doesn't auto-recognize the logon after login but at least I can add manually the credentials for the next times.

It fails also in the two steps logon sites (e.g: when first asks for the username and after clicking next, appears the password field, in sites like google or amazon, to name two which comes to mind just now).

It finally fails on (apache/nginx) basic authentication fields, I mean the old browser pop-ups.

iudex- commented 6 years ago

Those two step logon sites break because the password input is not visible when the auto fill tries to fill it. See line 50: https://github.com/nextcloud/passman-webextension/blob/2559133c529ae07a689c8cbe13e9221b099578e6/js/lib/findForm.js#L41-L52

Filling hidden password fields would fix this.

This can be tested with https://accounts.google.com by unhiding the password input with: document.querySelector("input[type=password]").setAttribute("class", ""); in the developer console and triggering the auto fill again via right click->autofill on the credential in the passman popup