search

nextcloud / passman-webextension

Webextension for the Passman Nextcloud app. Also offers browser extension & Android app.
https://passman.cc
GNU Affero General Public License v3.0
114 stars 43 forks source link

login and password fileds not recognised on certain sites #249

Closed jficz closed 6 years ago

jficz commented 6 years ago
### Steps to reproduce 1. go to https://ib.postovnisporitelna.cz/prihlaseni ### Expected behaviour Login and password field should either be pre-filled or at least have the blue shield icon on the right. ### Actual behaviour Nothing. Seems like form fields are not recognised by the extension. ### Configuration **Operating system**: Linux 64bit **Browser**: Firefox 59.0.2 **Extensions that might cause interference**: none (all other disabled) **Passman version**: 2.1.4 **Extension version**: 2.1.1 **Nextcloud version**: 13.0.0 #### Browser log JavaScript console empty, network logs without any errors or warnings.
brantje commented 6 years ago

Form tag is missing thus the extension can't detect it.

jficz commented 6 years ago

... and that's the reason to close this issue?

brantje commented 6 years ago

Yes, sites without a <form> tag are currently not supported.

jficz commented 6 years ago

Meaning that this issue is never going to be addressed? Why?

brantje commented 6 years ago

I said currently. Thus not at the moment but maybe in the future. The main problem is detecting the correct combination of fields (username + password). Then we have sites like Google / PayPal who show just 1 input field (and not even a hidden password type), making it even harder to detect a username field. Ofcourse i could try to fill every input on the page i can find (that is what #243 does), but that leads to problems on a lot of websites.

jficz commented 6 years ago

So when should I post this issue again?

(also, maybe some kind of manual field identification could help here, like "click to login field, click to pass field", or something like that; not sure if this is more passman or extension feature - as this would require either one to keep such metadata somewhere)