nextcloud / passman-webextension

Webextension for the Passman Nextcloud app. Also offers browser extension & Android app.
https://passman.cc
GNU Affero General Public License v3.0
114 stars 43 forks source link

extension frame closes when entering password fields [$10] #252

Open P1zz4br0etch3n opened 6 years ago

P1zz4br0etch3n commented 6 years ago

Steps to reproduce

  1. install passman extension
  2. open frame by clicking on passman icon
  3. click into password field (e.g. server credentials, master password)

Expected behaviour

The cursor should move into the field so you can enter your password

Actual behaviour

The whole frame disappears

Configuration

Operating system: Ubuntu 18.04 (upgraded from 16.04)

Browser: Firefox 59.0.2

Extensions that might cause interference: None

Passman version: 2.1.4

Extension version: 2.1.1

Nextcloud version: 13.0.1

Browser console log

[Passman extension] Stopping, vault key not set inject.js:400:21

--- There is a **[$10 open bounty](https://www.bountysource.com/issues/57850661-extension-frame-closes-when-entering-password-fields?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github).
chocolatine33 commented 6 years ago

Same behavior observed on Firefox 59.0.3

roccostorm commented 6 years ago

Confirm this behavior on Ubuntu only after Updating to 18.04 on FF 59.0.2 and 61.0b2. Works on Ubuntu 17.10 and Win 10 for current and dev FF Version.

augustseptember commented 6 years ago

Same behavior for me.

PhieF commented 6 years ago

Same

arnoldsuperstar commented 6 years ago

Same here. On a fresh install of Ubuntu 18.04 (FF 59.0.2).

PhieF commented 6 years ago

The problem comes directly from the type="password" of the field, so for my own user I've replaced it, which is bad :P

vilisseranen commented 6 years ago

Fresh install of Ubuntu 18.04, I have the same problem

PhieF commented 6 years ago

This bug isn't a passman bug https://bugzilla.mozilla.org/show_bug.cgi?id=1461591

gnuworldman commented 6 years ago

It seems that there was a regression in ibus possibly caused by the removal of a patch. Anyhoo, here are the steps for a near-fix* on a standard Ubuntu Desktop 18.04 setup:

There are other ways to effectively make the same change, some of which can make it apply to Firefox only, which you might want if changing the setting account-wide affects your ability to use compose keys in other apps. https://help.ubuntu.com/community/ComposeKey#XIM

* Although the above caveat was not a concern to me, this was, alas, not an otherwise perfect fix, as the Ctrl key still caused the browser extension dialog to close, but it made it a lot easier than hacking something in the browser's developer tools. I just have to remember to right-click+Paste instead of Ctrl+V when I'm not typing the password.

related bug threads: Ubuntu, Firefox, ibus

IBBoard commented 6 years ago

This won't help when using the extension to edit credentials, but if you want to add an account then I found a work-around.

Running Firefox from the command-line using GTK_IM_MODULE=xim firefox lets me input a password in the "Accounts" section. Once I'd created the account then I could close Firefox and re-open it to return to normal ibus input.

P1zz4br0etch3n commented 6 years ago

This is the real problem. I downloaded the attached deb file from this bugzilla and installed it. It's a recompiled version of the ibus package with an old patch applied that was removed for 18.04. They will find a better solution, but for now you can use that version. Worked perfectly for me. Here is the link: https://bugzilla.mozilla.org/attachment.cgi?id=8974077