nextcloud / passman-webextension

Webextension for the Passman Nextcloud app. Also offers browser extension & Android app.
https://passman.cc
GNU Affero General Public License v3.0
114 stars 43 forks source link

Don't send cookies to HTTP API #270

Closed marcelklehr closed 6 years ago

marcelklehr commented 6 years ago

Fixes #269 fixes #258

Happy keepyourpasswordssafe-ing again :)

wjwieland commented 6 years ago

So this is confirmed fixed on all platforms?

Version 68.0.3440.75 (Official Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit)

Passman still coming back with: Invalid response from server: [0] TypeError: Failed to fetch when re-installing the extension and trying to set up.

marcelklehr commented 6 years ago

@wjwieland Did you build and install the latest version or the patch I'm proposing here? The patch hasn't been reviewed, applied nor released, yet.

nhasbun commented 6 years ago

I applied this manually and it's working without problems on a Windows 10 machine.

wjwieland commented 6 years ago

@marcelklehr No, I did not. I am simply a user for which the current version (production) works on Google browser on Windose 10, but not in any version of Chromium nor Google Chrome on any version of Linux which is my main working platform. None of the Linux/Google combo's allow me to even set up (after uninstall) passman. They return the error mentioned in my previous post. I run the stable versions of all browsers on all platforms.

Essentially, my question is: Is this patch being tested on Linux/(browser-whatever)?

Thanks for your work on this. I count on passman and it is a real downer not having had it work for some time now.

marcelklehr commented 6 years ago

Essentially, my question is: Is this patch being tested on Linux/(browser-whatever)?

Yes. :)

wjwieland commented 6 years ago

@marcelklehr Thank you! :-)

jzielke84 commented 6 years ago

@marcelklehr When will the fix be included in the chrome web store?

marcelklehr commented 6 years ago

@jzielke-nli Ah, the github UI is a bit misleading here. I'm a nextcloud org member, but I'm not a passman maintainer. @brantje should be able to answer this one.

jamaale commented 6 years ago

Add me to the group of when will the patch finally be available. :/

jzielke84 commented 5 years ago

@brantje Please be so kind and publish the extension with that fix. All passman users have been sitting around with Chrome 67 for almost a month since version 68 came out. Thanks!

Freeben666 commented 5 years ago

How can I rebuild the extension myself ?

I tried swapping the api.js file in the extension folder in AppData, but Chrome noticed and declared the extension as corrupted...

When I try packaging the extension within Chrome, from the files cloned from Github, I get an error : "Variable $USERNAME$ used but not defined."

marcelklehr commented 5 years ago

You'll need to install node.js and npm, clone the repo, run npm install, npm install -g grunt, then run grunt build, judging from the files in the repo. I'm not sure if you already have the extension files ready at that point or if you still need to package the result. (Personally, I've switched to a different solution.)

jzielke84 commented 5 years ago

Regarding #269 and #270 Since not everyone is familiar with building stuff himself I've setup a Jenkins project. The latest version can be found here

Just tested successfully using Chrome 68.0.3440.106.

Freeben666 commented 5 years ago

Thank you jzielke, but being quite paranoid, I doubt I'll be using a pre-built unofficial version. I have a hard enough time trusting the official one with all of my passwords.

jzielke84 commented 5 years ago

@Freeben666 I'm aware of that. Just trying to help out a bit. Had the chance to meet @animalillo once personally and he asked me for contribution. I'd offer admin privileges for this Jenkins project to the devs so they can do code-proofing and integrate this project officially using sha256 checksums.

nhasbun commented 5 years ago

Stuck with Chromium here.

I know developers have a lot of work but this is a direct functionality issue. Can't use passman on Chrome at all since v68. You can still manually download the extension but you have a constant notification message on Chrome at start.