Fill fileds from search

[adocampo]

Hi guys! I wanted to writing this many months ago, and I never found the moment. But I think this passman behavior is so weird, it should be reported, so here I am.

At the moment, the search tool on the login form fields is pretty useless. It can search, but it cannot do anything useful, besides to show you have the credentials right there but you cannot use them. See image to figure what I'm trying to say.

It would be awesome to let user pick the credentials and fill the username and password fields in this moment. Just like if passman had find the proper credentials. Case uses? Every time passman decided you don't have the proper credentials (sometimes, passman gets confused with subdomains, or with URLs generated on the fly, but you know which credentials are exactly).

Steps to reproduce

1. Open a login form which passman doesn't know the credentials (or have some kind of problem with them)
2. Use the inline search tool
3. Try to click on the wanted credential

Expected behaviour

Passman should fill username and password fields with the selected credentials obtained by the search result.

Actual behaviour

Click does nothing.

Configuration

Operating system: Arch Linux

Browser: Firefox 62

Extensions that might cause interference: None

Passman version: 2.1.4

Extension version: 2.1.1

Nextcloud version: 13.0.6

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/64323137-fill-fileds-from-search?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github).

[wjwieland]

I agree about the functionality of this popup. I have attempted to edit entries in it, and they will work until one closes the current instance of chromium(or whatever browser), but those setting don't make it back to the server.....

[styx-tdo]

+1

[IBBoard]

I came to report a similar issue, but for the toolbar popup (it would be useful to copy from a search in there, rather than editing first). I hadn't thought of doing a copy from here!

From a quick bit of poking around, it looks like it should be fixed by #266? (Since this may be a duplicate of #251). Presumably we're waiting on a new release?

[Arc676]

Any update on this? This is still the case and it seems weird that this behavior is supposedly already fixed but the fixed version isn't released. That PR was merged over a year ago.

[Luckyvb]

plugin look for a form tag if fields not in form tag it don`t fill fields :

function getLoginFields(isSubmission) {
   var forms = document.forms;
    var loginForms = [];

    for (var i = 0; i < forms.length; i++) {
        var form = forms[i];
        var result = formManager.getFormFields(form, isSubmission);
        var usernameField = result[0];
        var passwordField = result[1];
        // Need a valid password field to do anything.
        if (passwordField === null){
            continue;
        }

        var res = [usernameField, passwordField];
        if(result[2]){
            res.push(result[2]);
        } else {
            res.push(null);
        }
        loginForms.push(res);
    }
    return loginForms;
}