nextcloud / passman-webextension

Webextension for the Passman Nextcloud app. Also offers browser extension & Android app.
https://passman.cc
GNU Affero General Public License v3.0
115 stars 43 forks source link

Firefox for android support [$100] #75

Open rodrigoaguilera opened 7 years ago

rodrigoaguilera commented 7 years ago

Steps to reproduce

  1. Install the addon on firefox for android (There is a suggestion for configuring it on the toolbar)
  2. Search for a way to configure the extension

Expected behaviour

I can config the extensión in a separate tab

Actual behaviour

The addon is installed but not configured

Configuration

Operating system: android 7.1.2

Browser: 53.0.2

Extensions that might cause interference:

Passman version: 2.1.2

Extension version: 1.2.12

Nextcloud version: 12.0.0

I wonder how difficult will be to add link to configure the addon. Is this or it requires more work?

--- There is a **[$100 open bounty](https://www.bountysource.com/issues/45919150-firefox-for-android-support?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github).
brantje commented 7 years ago

Firefox for android is not supported at the moment.

rodrigoaguilera commented 7 years ago

Thank you for you answer. I will donate in the meantime :)

I suggest you also put the donation links in the readme of this project.

brantje commented 7 years ago

Thanks! Will add them =)

rodrigoaguilera commented 7 years ago

Great!

Is there a possibility to declare the incompatibility with firefox for android. I feel people will get disappointed if they install and are not able to do anything with the addon rather than a clear message on the addons page that forbids the installation.

brantje commented 7 years ago

I've looked at the addon page, can't see anything to turn it off. @caitmuenster @wagnerand the extension is currently listed as an addon for Android, any way to turn this off?

rodrigoaguilera commented 7 years ago

If I find an example addon I will let you know. Thanks

brantje commented 7 years ago

Ah found it. Under release management i can choose not to distribute for Android.

rodrigoaguilera commented 7 years ago

Perfect!

On Thu, Jun 8, 2017 at 10:31 AM, Sander notifications@github.com wrote:

Ah found it. Under release management i can choose not to distribute for Android.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nextcloud/passman-webextension/issues/75#issuecomment-307036610, or mute the thread https://github.com/notifications/unsubscribe-auth/AAn_U1tg522sbi8-BhDAaYLbf5UzrexLks5sB7FpgaJpZM4NwbRU .

rugk commented 7 years ago

So how difficult is it to make it work for FF for Android? I assume also Fennec (codename for FF for Android) supports WebExtensions or will, at least, support it in the future, so it should be not that hard to make it work for Fennec, should not it?

brantje commented 7 years ago

No idea, but why? We have an android app that will support auto fill in the future.

rugk commented 7 years ago

Depends on how good this app works with Fennec…

rodrigoaguilera commented 7 years ago

So the app will communicate with any browser to autofill login forms?

animalillo commented 7 years ago

The app is on it's first stages, there will be a keyboard that will let you input the credentials or some other easy fill method that does not require copy-pasting stuff around and switching apps.

rugk commented 7 years ago

Okay, that's how other similar apps do it…

brantje commented 7 years ago

And Android 6 or 7 introduced and API for filling passwords.

Edit: Android O is going to support autofill

rugk commented 7 years ago

Android 6 or 7 introduced and API for filling passwords

…which should only be compatible/supported to/by Fennec.

brantje commented 7 years ago

Whats Fennec?

rodrigoaguilera commented 7 years ago

https://wiki.mozilla.org/Mobile/Fennec

brantje commented 7 years ago

Note to self: Connect phone to PC, press Shift + F8 to bring up the webide.

brantje commented 7 years ago

@rodrigoaguilera version 1.3.2 opens a new tab to configure the extension.

rodrigoaguilera commented 7 years ago

I just freshly installed the 1.3.2 of the add-on and the behavior I described didn't change. I wasn't able to see any config screen.

I try to inspect tools ➡ addons

But there I can only see a description of the addon

theCalcaholic commented 7 years ago

I can confirm that no settings tab is being opened after installing passman (as stated by @rodrigoaguilera). Could you perhaps provide the URL of said config page to help investigate the issue?

I think it would also be a good thing to have a settings menu entry for configuration changes. I actually forked the project (before I knew you had added this config page) to try contributing that functionality - but I'm still struggling to build the project for firefox.

brantje commented 7 years ago

As stated earlier, at this moment the firefox addon doesn't support Android. And with the android app in the pipeline i don't know if i have to spend energy on this. If we get auto fill working in the app, what would the benefit be of an Android firefox extension?

theCalcaholic commented 7 years ago

None, I'm just a bit sceptic towards how the autofill feature will work. But I'll happily be convinced. :D

I was just curious, because 5 days ago you said (as response to this issue) that the addon should now open a new tab after installation.

rodrigoaguilera commented 7 years ago

I fully support whatever the maintainers of think is the best way. Passman is not in a stage for duplicating efforts

theCalcaholic commented 7 years ago

Agreed.

tigermick commented 7 years ago

Hi ! I have installed passman extension for android firefox and impossible to set address, login and password about my nextcloud server .. Still not possible since last time please?

brantje commented 7 years ago

Not possible. We will focus on the Android app. That way all Android users can use passman, and not only firefox users.

theCalcaholic commented 7 years ago

Just a notice: As of Firefox 57 (current Beta) the passman extension works flawlessly.

rodrigoaguilera commented 7 years ago

@theCalcaholic Can you post some screenshots on how is the interface on android? I don't have a phone with me right now to install firefox beta

theCalcaholic commented 7 years ago

Sure. The Passman interface opens in its own tab instead of the popup you know from the desktop. Injection into Login forms works as usual.

When viewing a profile, the styling is not really mobile optimized, so some scrolling/zooming is required:

Just to show that passman has opened in its own tab:

poiNt3D commented 6 years ago

It works in Firefox beta 57, but if you close Firefox it will loose login settings.

theCalcaholic commented 6 years ago

@poiNt3D Unfortunately, yes.

bart886 commented 6 years ago

Hello Android 6, Firefox 56. I click in menu on passman and nothing works. Someone repair this extension?

brantje commented 6 years ago

Uhm did you even read the issue? Passman on Firefox for Android is currently not supported.

bart886 commented 6 years ago

Ok thanks. I go find other passwords manager.

brantje commented 6 years ago

We do have a Android app ;)

bart886 commented 6 years ago

Yes i now, but i want automatically write passwords. In app just copy and past on Firefox.

Jeltel commented 6 years ago

With Firefox Version 57 out now it does work. The interface is a bit small on my 1080p screen. But it works :)

brantje commented 6 years ago

Yea we have a PR pending for that, but commits are not signed so will port those =)

poiNt3D commented 6 years ago

Hooray! You are the best!

rugk commented 6 years ago

BTW as for signiong commits: You can use the command line instructions, GitHub shows at the PR at the bottom. THis will download it locally, merge it there and upload a (signed) version.

animalillo commented 6 years ago

but you need to rebase to keep the whole history signed

rugk commented 6 years ago

I think it is enough if the merge commit is signed… it includes all changes.

bart886 commented 6 years ago

@Jeltel on android?

Jeltel commented 6 years ago

Yes, on android

Op 17 nov. 2017 15:21 schreef "bart886" notifications@github.com:

@Jeltel https://github.com/jeltel on android?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nextcloud/passman-webextension/issues/75#issuecomment-345256160, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpvVEarpJWNWiXokvc7HsuzFLDTCK8hks5s3ZZbgaJpZM4NwbRU .

bart886 commented 6 years ago

OK it`s work. On mobile device scaled to a smaller screen it is great. I test passman some time. Thanks.

brantje commented 6 years ago

When #216 is merged, could you guy's test the master on Firefox for Android? If everything works then i'll release it to AMO & Chrome store.

JohnMH commented 6 years ago

@brantje I think it's safe to close this issue now.

poiNt3D commented 6 years ago

Firefox 57, Passman 2.0.4 still doesn't save settings Can anyone confirm?