nextcloud / passman

🔐 Open source password manager with Nextcloud integration
https://passman.cc
GNU Affero General Public License v3.0
786 stars 108 forks source link

vault password and shared passwords #285

Open jknockaert opened 7 years ago

jknockaert commented 7 years ago

There seems to be an issue with shared password when changing the vault password. I reproduced it on the demo server with two users alfa and beta:

  1. user alfa: create vault for alfa
  2. user beta: create vault for beta, add password and share it with alfa
  3. user alfa: accept share, change vault password and login to vault again

After step 3 a spinning wheel keeps spinning...

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/43348949-vault-password-and-shared-passwords?utm_campaign=plugin&utm_content=tracker%2F44880056&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F44880056&utm_medium=issues&utm_source=github).
maestroi commented 7 years ago

What version do you use?

jknockaert commented 7 years ago

@maestroi Whatever version is now on the demo server.

animalillo commented 7 years ago

I've checked this a little, the issue is easy to reproduce. I don't have time to check this further, but seems shared credentials are not properly reencrypted or skipped completely. I'll try to check this out some other day a bit more deeply

gschoenberger commented 7 years ago

It seems today I hit this bug and also #265 ? I tried to "unshare" a password I previously shared with a user from LDAP. But it seems now that I cannot share the same entry again. If i want to reshare it, the dialog keeps spinning at "Cyphering...". Moreover the pastebin symbol next to the entry seems not to work.

Just for clarification: is password sharing solid/safe? This is the most important feature for me besides LDAP, and if I cannot rely on it, I am quite stuck.

gschoenberger commented 7 years ago

I opened #349 for a detailed description of my problem, THX - Georg