search

nextcloud / polls

🗳️ Polls app for Nextcloud
https://apps.nextcloud.com/apps/polls
GNU Affero General Public License v3.0
257 stars 73 forks source link

Fix user search by email #3777

Closed come-nc closed 3 days ago

come-nc commented 1 week ago

Searching for users to share with by email was broken. This is due to 2 problems:

  1. The subname key for users had the wrong casing subName instead of subname
  2. The frontend filtering was active despite not being needed as backend already returns a filtered list
Before After
Copie d'écran_20241114_175310 Copie d'écran_20241114_175142

@dartcafe Is it safe to rename subName to subname or is used elsewhere? The only instance I could find is https://github.com/nextcloud/polls/blob/master/src/js/store/modules/acl.js#L16 and it looks pretty safe to rename if needed.

dartcafe commented 1 week ago

Renaming the subname seems to be no problem. As far as I remember, removing the filter removed the highlighting as well, since the match may also occur i.e. with the company name of a contact. But this seems to be no more the case.

dartcafe commented 1 week ago

Just for reference: https://github.com/nextcloud-libraries/nextcloud-vue/issues/6219

come-nc commented 3 days ago

@dartcafe Can this be merged? Should I ask the bot to "backport" to next?

dartcafe commented 3 days ago

Sure, I approved. :wink:

dartcafe commented 3 days ago

@come-nc Ah, no, backport not necessary. I did the backport already manually, just forgot to link that.

come-nc commented 23 hours ago

@dartcafe Would you consider releasing 7.2.5 so that this fix makes it to the appstore?