search

nextcloud / previewgenerator

Nextcloud app to do preview generation in the background.
https://apps.nextcloud.com/apps/previewgenerator
GNU Affero General Public License v3.0
461 stars 57 forks source link

Add support for usage with `encryption` (server side) #156

Open frlan opened 5 years ago

frlan commented 5 years ago

It would be awesome to generate also previews for NC instances using the server side crypto feature

Gerdal commented 5 years ago

I think there is possibility to do this but this is a little hacky: https://github.com/rullzer/previewgenerator/issues/47#issuecomment-543083549

flamingspaz commented 4 years ago

It wouldn't be perfect, but could there be an option to skip encrypted files? I only have external storages encrypted so it'd be nice if the local unencrypted images could have previews generated.

bcutter commented 4 years ago

Hi. As new attention is put on the E2EE (see current https://nextcloud.com/de/blog/production-ready-end-to-end-encryption-and-new-user-interface-arrive-with-nextcloud-desktop-client-3-0/) I was wondering what´s the progress of this issue. The inability of previewgenerator to handle encrypted setups is the one and only LAST reason for not using E2EE...!

Can´t we just implement @Gerdal´s hotfix (https://github.com/rullzer/previewgenerator/issues/156#issuecomment-543084713) in the next previewgenerator release?

sign-out commented 3 years ago

i would also enjoy support for encrypted setups even if it is slower or in some other way hampered. like accessing the files though the api so it is not encrypted but slow and resource intensive. anything would be better then nothing.

edit: in addition while im not versed in the project or php as well as id like it would be helpful to see and understand the technical reason this is hard to implement. if i had a guess i would say you generate the previews out side of next cloud entirely so when you look at an encrypted system all you get is junk data files. that being the case can you use the storage api in next cloud ? or is something blocking that? I apologize if my question is ignorant but it might help contributors make a path to having support as well.

AndyXheli commented 3 years ago

It would be nice to have encryption support on this app

sfatula commented 3 years ago

I would sure want this as well!

bcutter commented 3 years ago

I would sure want this as well!

Few people want, no one is willing or able to implement or even check if it's possible. See how old this issue is... 😑

bcutter commented 3 years ago

Still no progress. How can normal users contribute to make some progress here?

grafik

😢 😢 😢 😢 😢

teamfighter commented 2 years ago

+1 for that issue

mikeperalta1 commented 2 years ago

+1

bcutter commented 2 years ago

🪦

st3iny commented 2 years ago

Please do not bump the thread just to express your support. Use the :+1: reaction on the initial post if you'd like to support this feature request. Currently, there is no ETA for this feature but I acknowledged that there is some interest in the community.

The former maintainer already stated that it would be a lot of work and debugging to get it done right. I currently lack the time to work on this.

31337-4554551n commented 3 months ago

Would it still be overly complicated and not worth the effort to simply add a check for "is home folder encrypted" and if not, just do the thing?

By that I mean, don't try to work with encrypted files, but if encryption is just for external storages, then just don't touch external storages.