search

nextcloud / previewgenerator

Nextcloud app to do preview generation in the background.
https://apps.nextcloud.com/apps/previewgenerator
GNU Affero General Public License v3.0
455 stars 57 forks source link

Migration 19.0 to 20.0.14 problem with final stage : occ db:add-missing-indices return argument problems #269

Closed patricekaratchentzeff closed 2 years ago

patricekaratchentzeff commented 2 years ago

How to use GitHub

Hi,

Steps to reproduce

Migration auto from 19 to 20 from the web interface. Nice for all the stages until the last part by hands. When I try to

php occ db:add-missing-indices An unhandled exception has been thrown: ArgumentCountError: Too few arguments to function OCA\PreviewGenerator\Command\Generate::__construct(), 0 passed in /var/www/nextcloud/lib/private/Console/Application.php on line 224 and at least 5 expected in /var/www/nextcloud/apps/previewgenerator/lib/Command/Generate.php:72 Stack trace:

0 /var/www/nextcloud/lib/private/Console/Application.php(224): OCA\PreviewGenerator\Command\Generate->__construct()

nextcloud/server#1 /var/www/nextcloud/lib/private/Console/Application.php(136): OC\Console\Application->loadCommandsFromInfoXml(Array) nextcloud/server#2 /var/www/nextcloud/console.php(99): OC\Console\Application->loadCommands(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) nextcloud/server#3 /var/www/nextcloud/occ(11): require_once('/var/www/nextcl...')

In fact, all the php occ commands will failed php occ app:list An unhandled exception has been thrown: ArgumentCountError: Too few arguments to function OCA\PreviewGenerator\Command\Generate::__construct(), 0 passed in /var/www/nextcloud/lib/private/Console/Application.php on line 224 and at least 5 expected in /var/www/nextcloud/apps/previewgenerator/lib/Command/Generate.php:72 Stack trace:

0 /var/www/nextcloud/lib/private/Console/Application.php(224): OCA\PreviewGenerator\Command\Generate->__construct()

nextcloud/server#1 /var/www/nextcloud/lib/private/Console/Application.php(136): OC\Console\Application->loadCommandsFromInfoXml(Array) nextcloud/server#2 /var/www/nextcloud/console.php(99): OC\Console\Application->loadCommands(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) nextcloud/server#3 /var/www/nextcloud/occ(11): require_once('/var/www/nextcl...')

The server will run perfectly, but I can finalize the update.

Server configuration

Operating system: Debian 10.11 (up to date)

Web server: nginx 1.14

Database: Maria 10.3

PHP version: 7.3

Nextcloud version: 20.0.14

Updated from an older Nextcloud/ownCloud or fresh install: 19.0.x (last production issue)

Login as admin user into your Nextcloud and access 
http://example.com/index.php/settings/integrity/failed 
paste the results here.

No errors have been found.

List of activated apps: There're 30 ! Not possible all to copy-paste and the command line fails :(

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

unfortunatly, all my php occ commands would fail :(

Nextcloud configuration:

Config report Insert your config.php content here. Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …) ```

Are you using external storage, if yes which one: local/smb/sftp/... no

Are you using encryption: yes

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/... no

Client configuration

Browser: Firefox 95.0

Operating system:

Logs

Web server error log

Web server error log Nothing special from nextcloud server, only filters IP ban. #### Nextcloud log (data/nextcloud.log)
Nextcloud log {"reqId":"qvakJYaIPqxOev1K5epQ","level":1,"time":"2021-12-09T19:54:03+01:00","remoteAddr":"37.170.8.235","user":"--","app":"updater","method":"GET","url":"/core/ajax/update.php?requesttoken=oBzFpBT4iYcdUlfCDhuwacK1YJ1pEzqAzrgK6LUaT2s%3D%3A0mikxXKLvrF3MTSnV1DIDKnUS8wQRRHGmtVAgIZMKAQ%3D","message":"\\OC\\Updater::maintenanceDisabled: Turned off maintenance mode","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0","version":"20.0.14.2"} {"reqId":"qvakJYaIPqxOev1K5epQ","level":1,"time":"2021-12-09T19:54:03+01:00","remoteAddr":"37.170.8.235","user":"--","app":"updater","method":"GET","url":"/core/ajax/update.php?requesttoken=oBzFpBT4iYcdUlfCDhuwacK1YJ1pEzqAzrgK6LUaT2s%3D%3A0mikxXKLvrF3MTSnV1DIDKnUS8wQRRHGmtVAgIZMKAQ%3D","message":"\\OC\\Updater::resetLogLevel: Reset log level to Warning(2)","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0","version":"20.0.14.2"}
Thanks,
st3iny commented 2 years ago

Which version of previewgenerator are you using?

patricekaratchentzeff commented 2 years ago

3.4.0

Le mar. 14 déc. 2021 à 17:41, Richard Steinmetz @.***> a écrit :

Which version of previewgenerator are you using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nextcloud/previewgenerator/issues/269#issuecomment-993736259, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALIFZILXMWWEL6OH5LIQO3LUQ5XSLANCNFSM5JZ3GRXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- |\ ,,,---,, Patrice KARATCHENTZEFF ZZZzz /,.-'' -. ;-;;, @.*** |,4- ) )-,. ,\ ( '-' '---''(_/--'-'_)

st3iny commented 2 years ago

I could reproduce the issue and it's caused by https://github.com/nextcloud/previewgenerator/pull/190 on Nextcloud v20.

I'll develop a fix and publish a patch release asap.

patricekaratchentzeff commented 2 years ago

OK, thanks :)

Le mar. 14 déc. 2021 à 18:17, Richard Steinmetz @.***> a écrit :

I could reproduce the issue and it's caused by #190 https://github.com/nextcloud/previewgenerator/pull/190 on Nextcloud v20.

I'll develop a fix and publish a patch release asap.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nextcloud/previewgenerator/issues/269#issuecomment-993801313, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALIFZIM2BOR6FYVXHPRO733UQ532FANCNFSM5JZ3GRXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- |\ ,,,---,, Patrice KARATCHENTZEFF ZZZzz /,.-'' -. ;-;;, @.*** |,4- ) )-,. ,\ ( '-' '---''(_/--'-'_)

st3iny commented 2 years ago

Fixed by #273 and released with v3.4.1.

patricekaratchentzeff commented 2 years ago

Thanks for the reactivity.

How can I upgrade to 3.4.1 for testing?

Thanks,

Le mer. 15 déc. 2021 à 11:12, Richard Steinmetz @.***> a écrit :

Closed #269 https://github.com/nextcloud/previewgenerator/issues/269.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nextcloud/previewgenerator/issues/269#event-5770211802, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALIFZIPTQBHM7GJJBT2C63LURBSYHANCNFSM5JZ3GRXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- |\ ,,,---,, Patrice KARATCHENTZEFF ZZZzz /,.-'' -. ;-;;, @.*** |,4- ) )-,. ,\ ( '-' '---''(_/--'-'_)

patricekaratchentzeff commented 2 years ago

OK. It is automatic!

Nice job. All is fixed.

Thanks,

PK

Le mer. 15 déc. 2021 à 11:55, Patrice Karatchentzeff < @.***> a écrit :

Thanks for the reactivity.

How can I upgrade to 3.4.1 for testing?

Thanks,

Le mer. 15 déc. 2021 à 11:12, Richard Steinmetz @.***> a écrit :

Closed #269 https://github.com/nextcloud/previewgenerator/issues/269.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nextcloud/previewgenerator/issues/269#event-5770211802, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALIFZIPTQBHM7GJJBT2C63LURBSYHANCNFSM5JZ3GRXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- |\ ,,,---,, Patrice KARATCHENTZEFF ZZZzz /,.-'' -. ;-;;, @.*** |,4- ) )-,. ,\ ( '-' '---''(_/--'-'_)

-- |\ ,,,---,, Patrice KARATCHENTZEFF ZZZzz /,.-'' -. ;-;;, @.*** |,4- ) )-,. ,\ ( '-' '---''(_/--'-'_)