Empty directories left after removing previews of deleted images

nextcloud / previewgenerator

Nextcloud app to do preview generation in the background.

https://apps.nextcloud.com/apps/previewgenerator

GNU Affero General Public License v3.0

450 stars 56 forks source link

Empty directories left after removing previews of deleted images #303

Open pboguslawski opened 2 years ago

pboguslawski commented 2 years ago

When v5.0.0 removes preview files of deleted images, empty preview folders (i.e. appdata_oci2qpw7ky44/preview/e/a/5/d/2/f/1) are left which consumes resources (i.e. inodes) unnecessarily.

joshtrichards commented 3 months ago

AFAIK all deletion management is handled by the Server, not this app.

Specifically here:

https://github.com/nextcloud/server/blob/42c36c152bbbdb3b787da2b91b5702632fde81eb/lib/private/Preview/BackgroundCleanupJob.php#L65-L70

They should be getting deleted per nextcloud/server#35844, but from looking at the code I don't see how the folders ever get deleted (just files). 🤔