search

nextcloud / recognize

👁 👂 Smart media tagging for Nextcloud: recognizes faces, objects, landscapes, music genres
https://apps.nextcloud.com/apps/recognize
GNU Affero General Public License v3.0
564 stars 45 forks source link

Adding "Info" as a message type #1075

Closed Olen closed 10 months ago

Olen commented 10 months ago

Also added explicit "type=warning" to the relevant cards to add readability.

Should fix #1059

marcelklehr commented 10 months ago

Thank you for opening this! As is, I think this will not work however, as recognize is still using nextcloud-vue v7 which doesn't have the info type yet. So, we need to upgrade to nextcloud-vue v8, which I've been putting off because god knows what will break with that upgrade... :S

Olen commented 10 months ago

Ah, ok. This is my first PR for Nextcloud, so I am not familiar with all the dependencies. But it is at least a start, I hope. Someone with a better dev-environment than me should probably test the upgrade to v8. It will probably be required at some point anyway...

Olen commented 10 months ago

Uhm. That commit did not actually close this, did it? But it was a requirement for this PR to be merged?

marcelklehr commented 10 months ago

I merged your commit via cli: d2856ad9038621e510740ea6dd1b364bc88348b5

Olen commented 10 months ago

Thank you. Glad to see some development here. Recognize is great, but still needs a little love.

marcelklehr commented 10 months ago

Yeah, I completely agree. :)

github-actions[bot] commented 10 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!