search

nextcloud / recognize

👁 👂 Smart media tagging for Nextcloud: recognizes faces, objects, landscapes, music genres
https://apps.nextcloud.com/apps/recognize
GNU Affero General Public License v3.0
562 stars 45 forks source link

Add option to only retry non-tagged files in classify #1172

Closed nielstron closed 2 months ago

nielstron commented 2 months ago

This is picking up https://github.com/nextcloud/recognize/issues/1137 again.

Works locally, no idea how to unit test this :)

nielstron commented 2 months ago

This is now working on my server after I hacked it into the local settings.

marcelklehr commented 2 months ago

Hey @nielstron

Really cool that you're taking this on! I'll look into this soon

nielstron commented 2 months ago

Thanks for the clarification! Any suggestion on how to fix this?

nielstron commented 2 months ago

I see two options 1) Determine seperate whether the face classification pipeline has been run for a file and put it into the queue if not 2) always put the file in the face classification queue (which I fear to be quite expensive)

For 1 it would be good to know if such a tag exists/how to obtain it.

marcelklehr commented 2 months ago

Yeah, I agree with your assessment, for 1. you can find if a face detection exists for a file using the following method: https://github.com/nextcloud/recognize/blob/main/lib/Db/FaceDetectionMapper.php#L82

nielstron commented 2 months ago

If face detection for a file did not find a face, is the fact that we processed the file still stored somewhere? Or would this re-run classification on all files that don't contain a face?

marcelklehr commented 2 months ago

Ah, good question. There's no marker for whether a file has been through face recognition. It might make sense to introduce a new magic tag for this.

nielstron commented 2 months ago

Okay. This patch now skips running the no-face-recognition classification for tagged files. I don't think I will have time to contribute more elaborate features in the near future.

github-actions[bot] commented 2 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)