nextcloud / recognize

👁 👂 Smart media tagging for Nextcloud: recognizes faces, objects, landscapes, music genres
https://apps.nextcloud.com/apps/recognize
GNU Affero General Public License v3.0
553 stars 46 forks source link

Uninstalling the app does not cleanup database #621

Open storm1er opened 1 year ago

storm1er commented 1 year ago

Which version of recognize are you using?

3.3.4

Enabled Modes

Object recognition, Face recognition, Video recognition, Music recognition

TensorFlow mode

WASM mode

Which Nextcloud version do you have installed?

25.0.2

Which Operating system do you have installed?

Debian 11

Which Docker container are you using to run Nextcloud? (if applicable)

v23.0.1

How much RAM does your server have?

2GB

What processor Architecture does your CPU have?

ARM64

Describe the Bug

Uninstalling and removing recognize app does not remove any tables from recognize, neither cleanup their content

Expected Behavior

oc_recognize_* tables should be removed on uninstall or removal of the app

To Reproduce

Install then uninstall the app, check table list

Debug log

No response

marcelklehr commented 1 year ago

ocrecognize* tables should be removed on uninstall or removal of the app

There is no uninstall routine in Nextcloud, sadly. There is only a disable routine which I wouldn't want to trigger data removal.

kc9jud commented 1 year ago

See https://github.com/nextcloud/server/issues/5539 for tracking of the upstream issue.

storm1er commented 1 year ago

@marcelklehr

There is only a disable routine which I wouldn't want to trigger data removal.

I understand why you wouldn't want it, but:

Since the upstream issue has been created in 2017, waiting for it doesn't seem to be a good idea

MayeulC commented 1 year ago

This is actually quite handy in my case, as that means I can uninstall and reinstall the app without losing data: https://github.com/nextcloud/recognize/issues/628#issuecomment-1384241651