nextcloud / richdocuments

📑 Collabora Online for Nextcloud
https://nextcloud.com/collaboraonline
345 stars 116 forks source link

Dark mode with font color and parts of tool bar colors being very dark #3153

Open panomitrius opened 10 months ago

panomitrius commented 10 months ago

Describe the bug When having Nextcloud set to dark theme, the font color and also some parts of the toolbar icons are remaining black which makes them close to invisible.

To Reproduce I'm running nextcloud and nextcloud office on a docker setup, latest versions. Set theme to dark Open rich document

Expected behavior Font color and toolbar colors would change so to be clear and visible on the dark background.

Screenshots screenshot nextcloud office

Client details:

Server details

Operating system: Ubuntu 22.02 Docker

Web server: nginx reverse proxy

Database: mariadb

PHP version:

Nextcloud version: 27.0.2.1

Version of the richdocuments app: 23.05.3.1

Version of Collabora Online: 23.05.3.1

panomitrius commented 10 months ago

An update: when I change to dark mode within Nextcloud Office, the text shifts to visible white, but the the dark icons in the toolbar remains dark..

sceenshot nextcloud office 2

juliushaertl commented 10 months ago

This seems to be a regression with the latest code build, I'll have a look.

MoritzDPTV commented 8 months ago

Is it possible to set the Nextcloud Office default theme globally for all users independently from the defined Nextcloud theming?

joshtrichards commented 8 months ago

This appears to have been fixed in newer versions of CODE.

Or at least I can't reproduce it and there appear to be some relevant items in the release notes for >=23.05.4:

https://www.collaboraoffice.com/code-23-05-release-notes/

Are you still seeing this, @panomitrius?

digitalrevisor commented 7 months ago

Hi, we still have this issue with Collabora version 23.05.5.4, and Nextcloud Office version 8.2.3 Nextcloud version is 27.1.4

AndyXheli commented 7 months ago

still an issue COOLWSD version: 23.05.5.4

NC Server 27.1.4

image

juliushaertl commented 7 months ago

This very much depends on the document that you use (or template this is created from)

It would be good to know how you created that file and what file format it is using.

It is likely that for the case where this happens the font color is set to black on the new document instead of "Automatic" (see screenshot below) One can manually change that, but would of course be good to fix this in whatever case this still occurs.

Screenshot 2023-12-06 at 16 06 16
AndyXheli commented 7 months ago

The file was created in excel outside of nextcloud.

juliushaertl commented 7 months ago

Interesting. I think MS Office also has a dark mode so would be curious how the file is rendered there?

AndyXheli commented 7 months ago

Here what it look like in Excel. Excel dose not darken the fields

image

pabloeisenhut commented 7 months ago

I think the solution from Nextcloud Office with the dark background is nicer, but the font color would have to be light in dark mode. IMHO

AndyXheli commented 7 months ago

Yea personally not a big fan! but that's a personal preference

juliushaertl commented 7 months ago

@pedropintosilva I'm wondering if there is anything that could be done around that. Not sure if any automatic way makes sense as one might still want black text in some areas.

Just a wild idea: Maybe we can provide the user with a hint/option to convert black text to default color if detected?

pabloeisenhut commented 7 months ago

For comparison, I had a look at Microsoft Online Office, there the font color is automatically adjusted.

1 2

surfrock66 commented 6 months ago

Additional details, there is a huge UI issue between the "Dark Theme" and "Dark Theme with High Contrast Mode" nextcloud themes.

Dark Theme: image

Dark Theme with High Contrast Mode for the same document: image

Collabora is it's own vm, 23.05.6.4. Nextcloud is on Ubuntu Server 22.04, v27.1.5 Nextcloud Office app 8.2.3

sskokorin commented 6 months ago

My only wish is to be able to disable the dark mode for all users forever

mwinkens commented 5 months ago

Totally readable table right? This is full of data. Currently users can toggle darkview in the View field which doesn't affect nextcloud. So you have lightview in collabora and nightview elsewhere. I wish for a button to disable darkview for every user in collabora.

Bildschirmfoto vom 2024-01-26 13-56-20

pedropintosilva commented 5 months ago

Thank @mwinkens for taking the time to test, report and attach the screenshot. It really helps!

Totally readable table right? This is full of data.

Could you please attach here the document? I think what's happening is that the document is being created with text styles that have static colour (in this case Black).

I have just tried, on my end, and creating a spreadsheet in Nextcloud doesn't make use of hard coded black (the styles have auto which means they change depending on the mode).

Nevertheless this doesn't solve the problem of already created documents with styles that are set to Black or White within or outside of Nextcloud (example: the user might want to print something with white text color on a colourful paper or on shape etc). Which leads to the question: should we just ignore the colours which the document was created with? At least when darkmode is toggle on? And all of them or just the styles with lack of contrast?

Currently users can toggle darkview in the View field which doesn't affect nextcloud. So you have lightview in collabora and nightview elsewhere. I wish for a button to disable darkview for every user in collabora.

This seems to be a distinct comment but I'm not sure I understand. If I understood correctly you are hinting at the fact that inconsistency is undesirable/not wanted(?) Could you please expand on that?

mwinkens commented 5 months ago

@pedropintosilva I think this has nothing to do with static colors, this is a xlsx file coming from (microsoft) excel, which is opened with the default dark mode setting from nextcloud. I tried to reproduce this with a normal .ods table and there the font was white on black and not black on black. The user who created the file does use light theme, in excel and nextcloud.

I can't give you the original file, but I managed to reproduce this in a test file

test.xlsx

dunkler-modus

This seems to be a distinct comment but I'm not sure I understand. If I understood correctly you are hinting at the fact that inconsistency is undesirable/not wanted(?) Could you please expand on that?

Do you see the big red button in the screenshot saying "Dunkler Modus", when I klick that I can switch to light theme inside collabora making the table white and looking usable again:

dunkler-modus2

Edit: I exported the same file as .ods, and managed to produce the same error there:

test2.ods

mejo- commented 2 months ago

I just experienced the same issue when I created a new spreadsheet from Nextcloud Files in dark mode (reproducible on the company instance). In Nextcloud appearance settings, system default theme is configured. But switching to dark theme there doesn't change anything.

2024-04-25T23:40:03,275010246+02:00

DaanSelen commented 2 months ago

This issue is still there, dark mode is very dark. Can I disable this or make the bright mode default?

kwaun commented 2 months ago

Same issue. When I set my browser (Brave) configured as "Auto Dark Mode for Web Contents": Default (Disabled), the page looks perfect in Dark Mode.

pure-dark-mode

But when I configure my browser as "Auto Dark Mode for Web Contents": Enabled, the toolbar icons look way too dark in Dark Mode.

browser-dark-mode

It seems like an icon palette color issue. The document looks fine btw.

collabora/code:24.04.2.1.1 nextcloud:29.0.0-apache

DaanSelen commented 2 months ago

I have seen that Collabora has some trouble with finding certain dark icons with the latest docker image, could that be it?

phirestalker commented 2 weeks ago

I can't find the option in collabora spreadsheet to set the text color to auto. Where is it located?