search

nextcloud / richdocuments

📑 Collabora Online for Nextcloud
https://nextcloud.com/collaboraonline
345 stars 117 forks source link

richdocuments effectively disables ability to open files with Collabora if onlyoffice app is installed #3456

Open gchatthes opened 5 months ago

gchatthes commented 5 months ago

Describe the bug If richdocuments detects onlyoffice app, it completely disables handling of any documents which are also compatible with onlyoffice. This shouldn't be the correct approach, since it effectively allows only a few extensions to be handled by richdocuments and the user has no way of opening file with those disabled extension with Collabora. Furtermore, onlyoffice allows to open any documents from the context menu so the correct approach would be to have richdocuments handle all office documents by default and if user want's to open a document with onlyoffice, he can do so by opening the context menu and selecting the option to open onlyoffice. The code which handles this is in file: ./lib/Service/CapabilitiesService.php Deleting/commenting out this section fixes the issue

        if ($this->appManager->isEnabledForUser('onlyoffice')) {
            return true;
        }

To Reproduce Steps to reproduce the behavior:

  1. install onlyoffice app (no need to configure it)
  2. Click on any document which is supported by onlyoffice (docx, xlsx etc.)
  3. Documents either open with onlyoffice (if correctly configured), or a download dialog appears

Expected behavior If the document is supported by richdocuments it should open Collabora. If user wants to open it with onlyoffice, he can do so by selecting the appropriate option in the context menu.

Client details:

Server details

Operating system: Debian 12 Bookworm / Docker install (latest)

**Web server: Apache/2.4.57 (Debian) / within docker

**Database: Mariadb, docker image version latest (11.2.2)

**PHP version: php 8.2.15

**Nextcloud version: 8.0.2

**Version of the richdocuments app: 8.3.1

**Version of Collabora Online: 23.05.8.4

chunsiyang commented 4 months ago

same here with the following environment nextcloud 28.0.3 nextcloud office 8.3.2 Collabora server 23.05.9.3 11d108b onlyoffice 9.0.0

thebearon commented 3 months ago

This is since #2301, made for #2281.

unnilennium commented 3 months ago

confirm the behaviour which is new after upgrade from 26 to 28.0.4 One could prefer onlyoffice for some use case and keep richdocument for all other documents !

could we just exclude document type explicitly selected in onlyoffice configuration, letting also option to "open with collabora using contextual menu"