nextcloud / richdocuments

📑 Collabora Online for Nextcloud
https://nextcloud.com/collaboraonline
349 stars 115 forks source link

[Bug]: Unable to uncheck 'restrict usage/edit to specific groups' in Nextcloud Admin Settings #3506

Closed isdnfan closed 3 months ago

isdnfan commented 6 months ago

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://cloud.mydomain/settings/admin/richdocuments)'
  2. Check the checkbox 'restrict usage to specific groups'
  3. try to unCheck the checkbox 'restrict usage to specific groups'
  4. in browser console see error 'TypeError: this.value.filter is not a function'

Expected behavior settings could be checked/unchecked

Screenshots image

Client details:

Server details

Operating system: docker community edition Web server: Apache Database: MariaDB PHP version: 8.2 Nextcloud version: 28.0.2 Version of the richdocuments app 8.3.1 Version of Collabora Online 23.05.6.4 Configuration of the richdocuments app

    "richdocuments": {
      "canonical_webroot": "",
      "doc_format": "",
      "edit_groups": "",
      "enabled": "yes",
      "external_apps": "",
      "installed_version": "8.3.1",
      "public_wopi_url": "https://collabora.mydomain.tld",
      "types": "prevent_group_restriction",
      "use_groups": "",
      "wopi_allowlist": "172.16.0.0/12,fd00:feed:beef::/48",
      "wopi_url": "https://collabora.mydomain.tld"
    }

initially reported at https://help.nextcloud.com/t/nextcloud-collabora-code-docker-compose-almost-everything-is-working-except-it-isnt/183450

isdnfan commented 6 months ago

similar to #3377

lftsy commented 5 months ago

FYI, here is the woraround I used

root@ifrit:[~]# sudo -u www-data php --define apc.enable_cli=1 /var/www/nextcloud/occ config:app:delete richdocuments use_groups
Config value use_groups of app richdocuments deleted

root@ifrit:[~]# sudo -u www-data php --define apc.enable_cli=1 /var/www/nextcloud/occ config:app:delete richdocuments edit_groups
Config value edit_groups of app richdocuments deleted
RealKoenisch commented 4 months ago

This bug goes even deeper. In case you limit the usage of office by restricing the groups (1st option), for all non listed groups the folder management is broken - click on o folder for users in groups without office access will lead to a download, instead of opening the folder; right click on the folder will not shown the nextcloud menu, the display of the the shared sources is not shown (icon is missing) and finally the 3-horizontal dots are missing as well.

User of a group without access to office image

User with access to office image

image

KR

steadfasterX commented 4 months ago

I can confirm what @RealKoenisch wrote, see: https://help.nextcloud.com/t/upgrade-28-29-right-click-menu-stopped-working/190537

RealKoenisch commented 4 months ago

This bug goes even deeper. In case you limit the usage of office by restricing the groups (1st option), for all non listed groups the folder management is broken - click on o folder for users in groups without office access will lead to a download, instead of opening the folder; right click on the folder will not shown the nextcloud menu, the display of the the shared sources is not shown (icon is missing) and finally the 3-horizontal dots are missing as well.

User of a group without access to office image

User with access to office image

image

KR

In the actual release Version I can limit again the access to office without breaking the folder management. Unchecking is still buggy.

KR Koenisch