nextcloud / richdocuments

📑 Collabora Online for Nextcloud
https://nextcloud.com/collaboraonline
349 stars 115 forks source link

Popup "Check security warnings of your server" cannot be discarded #3755

Closed jmechnich closed 3 months ago

jmechnich commented 3 months ago

Describe the bug After upgrade to Collabora CODE 24.04.4.1.1, a popup appears repeatedly while editing a document with the message "Check security warnings of your server" (screenshot 1). Opening the details, there are two possible outcomes: either there are no issues found but a notice "The is_admin user property is set" (screenshot 2) or an actual error "The is_admin user property is not set" (screenshot 3). See also this post in the Nextcloud help forum.

To Reproduce Steps to reproduce the behavior:

  1. Check that Collabora CODE 24.0.4.4.1.1 is installed.
  2. Open a text document using Collabora.
  3. Start editing and wait for the popup to appear.

Expected behavior No popups or at least no recurrence after checking their contents.

Screenshots Screenshot 1: image

Screenshot 2: image

Screenshot 3: image

Client details:

Server details

Operating system: Debian bookworm

Web server: Apache/2.4.59 (Debian)

Database: mariadb Ver 15.1 Distrib 10.11.6-MariaDB

PHP version: PHP 8.2.18

Nextcloud version: 28.0.6

Version of the richdocuments app 8.3.7

Version of Collabora Online collabora/code:24.04.4.1.1 Docker image

Configuration of the richdocuments app

{
    "apps": {
        "richdocuments": {
            "disable_certificate_verification": "",
            "enabled": "yes",
            "installed_version": "8.3.7",
            "public_wopi_url": "https:\/\/redacted.host.name",
            "types": "prevent_group_restriction",
            "wopi_allowlist": "172.0.0.0\/8",
            "wopi_url": "https:\/\/redacted.host.name\/"
        }
    }
}
Logs #### Nextcloud log (data/nextcloud.log) ``` (empty) ``` #### Browser log ``` ... Unknown server audit entry: certwarning bundle.js:24657:46 ... ```
joshtrichards commented 3 months ago

This is a Collabora Online/CODE matter. It also looks like it's been addressed just recently:

https://github.com/CollaboraOnline/online/pull/9229 https://github.com/CollaboraOnline/online/pull/9242

EDIT: Though we may need to audit our use of is_admin. Looks like some deprecation. Looking now...

EDIT2: Deprecation dealt with in #3748 yesterday. :)