nextcloud / richdocuments

📑 Collabora Online for Nextcloud
https://nextcloud.com/collaboraonline
344 stars 117 forks source link

fix: Uncheck group limit in admin settings #3758

Closed elzody closed 2 weeks ago

elzody commented 3 weeks ago

Summary

Previously, trying to uncheck the checkbox would simply re-enable it automatically. This PR fixes this issue. Also adds an inputLabel prop to the NcSelect so it doesn't error anymore (and accessibility reasons :D)

https://github.com/nextcloud/richdocuments/assets/23369449/3940d131-83a1-49e3-a8b3-af656070c70a

Checklist

juliushaertl commented 3 weeks ago

Thanks for looking into this. We used to hide the select if the box was unchecked. Maybe we can bring back this behaviour as well?

juliushaertl commented 2 weeks ago

/backport to stable29

juliushaertl commented 2 weeks ago

/backport to stable28

juliushaertl commented 2 weeks ago

Quick tip: Feel free to already comment with the backport requests when opening the PR, that way the backports will get scheduled once merged. Makes it a bit easier to not miss them :)