search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.32k stars 4.06k forks source link

Footer link to text (Theming App) #10024

Closed hume1991 closed 6 years ago

hume1991 commented 6 years ago

Hello,

I use the Theming App Version: 1.4.5. I would like to display the footer link as text. Which file has to be edited? Link to the cloud: https://www.cloud.geonativ-energie.de

Best regards

Christian Huml

nextcloud-bot commented 6 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/9479 (Theming App Problem), https://github.com/nextcloud/server/issues/5547 (When sharing "Upload Only" link, have theme background), https://github.com/nextcloud/server/issues/4807 (Add a dark theme to theming app), https://github.com/nextcloud/server/issues/9851 (Upload the logo in Theming App failed), and https://github.com/nextcloud/server/issues/7100 (Theming app and ImageMagick).

MorrisJobke commented 6 years ago

I guess there is no way to disable it as of now. IMO we should also not add yet another option here. Just set it to the URL of your instance.

Or what is the motivation of this request?

cc @nextcloud/theming @jancborchardt

juliusknorr commented 6 years ago

Yes, we should not introduce another option here. You could also easily hide the link with the theming_customcss app.

hume1991 commented 6 years ago

I would have thought it is open source? I can not make any customization on my own server? I am very well good in programming and HTML and CSS. That's not a solution for me. If it continues like this, I will set up a cloud myself.

Best regards

Christian Huml

MariusBluem commented 6 years ago

Uhmmm ... @hume1991 - I think you did understand something wrong here. You are allowed to make as many changes to the code you want as long as it keeps compatible with the AGPLv3-License the code is licensed with.

This discussion was about what is possible with the current features/implementations in the settings. So customzie your own Nextcloud instance and feel free to open a pull request here on GitHub if you think your enhancement would be a good addition to Nextclouds code ;)

juliusknorr commented 6 years ago

@hume1991 As @MariusBluem said, there is nothing limiting you from changing things on your server. Since the GitHub issue tracker is used to track enhancement requests and bug reports, we discuss here how and if requests can be integrated. You might want to checkout https://help.nextcloud.com for questions regarding customization or other questions that are not bug reports or feature requests.

Besides that, core/templates/layout.guest.php might be the file you are looking for, but custom changes will of course be overwritten by every update.

MorrisJobke commented 6 years ago

I would have thought it is open source? I can not make any customization on my own server? I am very well good in programming and HTML and CSS. That's not a solution for me. If it continues like this, I will set up a cloud myself.

Keep also in mind that open source does not mean, that every feature that can be imagined will be implemented. We think about it and then decide if it should be in the product or not. Keep also in mind that once it is in we as maintainers also need to take care of it for the next years and keep it working. Thus we decide carefully what to add and what not.

hume1991 commented 6 years ago

Can I submit a request for the code of the theming app? Would expand it.

Best regards

Christian Huml

juliusknorr commented 6 years ago

@hume1991 Sure any contribution is welcome there. But as said above, there should not be another option for that, since the theming app settings are already quite long and complex and adding another checkbox for a setting that has a very small target group of users conflicts with our goal to do things automatically instead of offering configuration options. (See our design guidedlines)

If you can come up with a different solution, feel free to propose it for discussion here. :+1:

MorrisJobke commented 6 years ago

Can I submit a request for the code of the theming app? Would expand it.

As @juliushaertl pointed out: let's discuss first the possible solutions here. For this it would be super helpful if you explain the reason for this option. Maybe we can come up with a better idea to fix this problem.

hume1991 commented 6 years ago

@juliushaertl @MorrisJobke

I see something critically opposed to links. Since with us that German law is authoritative, it can possibly lead to warnings. Besides, it can be irritating for the users. If necessary I have to develop my own app that uses the parameters of the theming app.

Best regards

Christian Huml

MorrisJobke commented 6 years ago

I see something critically opposed to links. Since with us that German law is authoritative, it can possibly lead to warnings. Besides, it can be irritating for the users. If necessary I have to develop my own app that uses the parameters of the theming app.

Could you rephrase this, because I don't get what a link has to do with German law, warnings and the need to avoid links?

hume1991 commented 6 years ago

@MorrisJobke

It is about the disclaimer. Each additional link has a certain liability.

Best regards

Christian Huml

jancborchardt commented 6 years ago

How about: If a link isn't set in the theming app, simply don't linkify the name in the footer? @juliushaertl?

juliusknorr commented 6 years ago

How about: If a link isn't set in the theming app, simply don't linkify the name in the footer?

Yes that should work fine. Good idea @jancborchardt

It is about the disclaimer. Each additional link has a certain liability.

I still don't see how a link to the page itself could have influence the liability there, but if we go with the approach @jancborchardt proposed, it should be fine, right @hume1991 ?

We then need to adjust the footer generation here: https://github.com/nextcloud/server/blob/8aaf2c32729fcd0302f79546f396a07398f0d724/apps/theming/lib/ThemingDefaults.php#L154

Are you still interested in contributing? Feel free to open a pull request with the change. :wink:

hume1991 commented 6 years ago

@jancborchardt @juliushaertl

Would be in my sense. :)

Best regards

Christian Huml

jancborchardt commented 6 years ago

@hume1991 cool! Then as @juliushaertl said:

Are you still interested in contributing? Feel free to open a pull request with the change. :wink:

Thank you! :)

hume1991 commented 6 years ago

I am currently testing. What other files are affected except: server/apps/theming/lib/ThemingDefaults.php?

List:

theming/appinfo/info.xml theming/js/settings-admin.js /theming/lib/Controller/ThemingController.php /theming/lib/Capabilities.php /theming/lib/ThemingDefaults.php /theming/templates/settings-admin.php

Everything? Did I forgot something?

Best regards

Christian Huml

juliusknorr commented 6 years ago

@hume1991 You should be able to just add a check to the ThemingDefaults->getShortFooter() method, that will not return a link when the url is empty. I'm not sure why the other files you have listed should be affected by the change?

hume1991 commented 6 years ago

@juliushaertl

I would have thought the link should be officially removed from the theming app? The variables and the text output (Theming App) would then have to be edited accordingly.

Where can I find (theming app) pull request?

Best regards

Christian Huml

juliusknorr commented 6 years ago

@hume1991 Maybe you have got the discussion wrong then, the plan is to only remove the link only if the link value inside the theming app is empty. If a link has been set, nothing will change.

hume1991 commented 6 years ago

@juliushaertl

Ok, now I understand. Then only: server/apps/theming/lib/ThemingDefaults.php is affected.

Edit:

If the field is empty, the text is no longer output. The text should still be output, but without a link.

Best regards

Christian Huml