nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.4k stars 4.07k forks source link

Thunderbird 60.x unable to use caldav/carddav #10134

Closed egal88 closed 5 years ago

egal88 commented 6 years ago

When trying to access calendar (Lightning) and addressbooks (CardBook) on a Nextcloud 13.0.4 server, Thunderbird 60.0b9 receives status 503 from the server and therefor cannot access any data.

Using Thunderbird 52.x everything works as expected.

Cross reference see https://bugzilla.mozilla.org/show_bug.cgi?id=1468912

The admin of our webserver tried the same with owncloud 7.0.4, but he did not test newer versions. Using this really old version of owncloud, Thunderbird 60.0b9 manages to access the caldav and carddav urls without any error. Since Nextcloud is a fork of owncloud, it might be, that the described issue is not Thunderbird related. Perhaps the bug has to be searched for in Nextclouds code.

nextcloud-bot commented 6 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/8766 (Caldav ), https://github.com/nextcloud/server/issues/6291 (Thunderbird/Lightning Events pop up after each caldav update), https://github.com/nextcloud/server/issues/3031 (Carddav/Caldav api confusion), https://github.com/nextcloud/server/issues/8469 (Allow remote caldav/carddav servers), and https://github.com/nextcloud/server/issues/8500 (Unable to access CalDAV as LDAP authenticated user).

painxcess commented 6 years ago

I can confirm a working Thunderbird 60.x with ownCloud 10.0.2. I can confirm a not working Thunderbird 60.x with Nextcloud 11.0.3 and nextcloud 12.0.9.

MorrisJobke commented 6 years ago

cc @georgehrke

egal88 commented 6 years ago

Thunderbird 60.0b10 still has the same issue

biva commented 6 years ago

We might be investigating the same issue here: https://gitlab.com/CardBook/CardBook/issues/306 and https://bugzilla.mozilla.org/show_bug.cgi?id=1468755

Could you confirm that TB60 beta 4 did not have the issue, while beta 5 and following have it? (you can find these versions here: https://filehippo.com/fr/download_thunderbird/history/

biva commented 6 years ago

And for reference, I closed my initial issue because I thought it was cardbook related: https://github.com/nextcloud/server/issues/9869

@egal88 could you correct your bugzilla link (it's broken)?

painxcess commented 6 years ago

I can confirm:

egal88 commented 6 years ago

@biva Bugzilla link corrected. Thanks for your info.

biva commented 6 years ago

@georgehrke @MorrisJobke Thunderbird developers ask for Nextcloud developers' support in https://bugzilla.mozilla.org/show_bug.cgi?id=1468912#c33 as it might be specific to Nextcloud. Could you have a look?

MorrisJobke commented 6 years ago

@georgehrke Could you answer their questions, as you know a bit more about it.

MorrisJobke commented 6 years ago

Or maybe @rullzer regarding the auth stuff.

biva commented 6 years ago

@rullzer and @georgehrke It looks like if this issue happens with Nextcloud server only. Could you have a look at this Thunderbird issue? https://bugzilla.mozilla.org/show_bug.cgi?id=1468912#c54

biva commented 6 years ago

@adi-dev @georgehrke @rullzer Thunderbird 60 has been released and this issue is the single "Known Issues" in the release notes https://www.thunderbird.net/en-US/thunderbird/60.0/releasenotes/

And apparently, only Nextcloud is having this issue. Thunderbird developers are begging for a support from Nextcloud to investigate this (https://bugzilla.mozilla.org/show_bug.cgi?id=1468912#c61). Could you have a look?

georgehrke commented 6 years ago

When I took a look a couple of days ago it seemed to be related to Nextcloud in a subdirectory. Can anyone confirm this?

Looking into a proper fix now ..

biva commented 6 years ago

it seemed to be related to Nextcloud in a subdirectory. Can anyone confirm this?

I'm not sure to understand your question. I'm having the issue and my Nextcloud is installed in /var/www/html/nextcloud and the url is https://nexcloud.mywebsite.com

adi-dev commented 6 years ago

Just out of curiosity, my httpd logs are full of:

503 Service Unavailable
    /remote.php/dav/calendars/username/contact_birthdays/: 8 Time(s)
    /remote.php/dav/calendars/username/pers ... 18671aca94f.ics: 8 Time(s)
    /remote.php/dav/calendars/username/pers ... 2B019A7E39A.ics: 8 Time(s)
    /remote.php/dav/calendars/username/pers ... 746adb10b4e.ics: 8 Time(s)
    /remote.php/dav/calendars/username/personal/: 8 Time(s)
    /remote.php/dav/calendars/username/work ... 3205226d8d2.ics: 8 Time(s)
    /remote.php/dav/calendars/username/work ... 424356a20b3.ics: 8 Time(s)
    /remote.php/dav/calendars/username/work ... 8f14bfddd52.ics: 8 Time(s)
    /remote.php/dav/calendars/username/work ... 98e7d1e3e30.ics: 8 Time(s)
    /remote.php/dav/calendars/username/work ... ac01859d6df.ics: 8 Time(s)
    /remote.php/dav/calendars/username/work ... afbc4852481.ics: 8 Time(s)
    /remote.php/dav/calendars/username/work ... d04937ec4a4.ics: 8 Time(s)
    /remote.php/dav/calendars/username/work/: 8 Time(s)

I set up my Thunderbird as CalDAV, is it normal it requests .ics files? Any clues?

j-ed commented 6 years ago

@georgehrke I just read the description of the Thunderbird bug report and it seems that the interesting part starts at comment 43. By disabling the newly introduced parameter network.cookie.same-site.enabled the problem can be solved. So it seems to be a kind of cookie handling problem?!

georgehrke commented 6 years ago

By disabling the newly introduced parameter network.cookie.same-site.enabled the problem can be solved. So it seems to be a kind of cookie handling problem?!

Yes, there is an issue with the cookie handling. I'm talking to the person at Mozilla who implemented it to see what causes this issue and how we can resolve it.

As a workaround:

(as described in Thunderbird's release notes):

For your own security you should set it back to true once this issue is resolved.

adi-dev commented 6 years ago

I can confirm, the workaround works for me, cheers

JSoko commented 6 years ago

No problems with old installations upgraded to Thunderbird 60.

After creating a new profile in TB 60. had the problem with caldav and carddav under cardbook. The network.cookie.same-site.enabled works, but I think, Thunderbird should work out of the box...

goddib commented 6 years ago

When I took a look a couple of days ago it seemed to be related to Nextcloud in a subdirectory. Can anyone confirm this?

I can tentitavely confirm this (even though I assume debugging has moved beyond this point). I was actually going mad trying to figure out why one of my up-to-date nextcloud instances (in root folder) would sync as usual after the TB60 update and the other one wouldn't (in sub-folder, TB actually receives a 503). Especially as both kept synching with DAVDroid and react to curl.

The work around seems to work for me as well. Keep up the good work, thanks everyone!

biva commented 6 years ago

Yes, there is an issue with the cookie handling. I'm talking to the person at Mozilla who implemented it to see what causes this issue and how we can resolve it.

Hello @georgehrke, Did you find the causes?

georgehrke commented 6 years ago

Did you find the causes?

No, we are still looking for what causes this. If we know more, I will comment here.

MichaIng commented 6 years ago

👍 Great both sides are working on this, this issue drove me crazy for the last two days 🤣.

biva commented 6 years ago

Still no idea about the cause? Thanks for your investigation.

criwe commented 6 years ago

I´m syncing two thunderbirds (both 60.0) on two computers with the same Nextcloud-Installation. Both same system (win7), but one is 32bit, the other is 64bit. The 32bit system seems to work fine (thunderbird syncs like expected), the 64bit doesnt want to sync (execpt using the workaround described above). May that helps...

painxcess commented 6 years ago

I can't confirm a working Windows 7 Pro in 32 Bit with Nextcloud 13.0.6. (Tested a fresh Win7-Install 32 Bit with all updates and Thunderbird 60)

mbiebl commented 6 years ago

I'm also hit by this bug. What's interesting for me though, that I only have this problem with a fresh TB profile. With an existing TB profile where I've setup lightning a long time ago, the calendar sync works.

mnlipp commented 6 years ago

@mbiebl cannot confirm the "only fresh profile" observation. Just tested two thunderbirds with year old profiles and had to activate the work-around for both.

criwe commented 6 years ago

@mnlipp: can confirm that old profiles got the problem too.

I´ve updated Nextcloud from 13.x to 14.01, but still the same issue...

rullzer commented 6 years ago

I'm not sure but https://github.com/nextcloud/server/pull/11433 might fix this.

criwe commented 6 years ago

@rullzer looks good. I´ve tested with two installations, in both syncing works fine now. But would be cool, if some other thunderbird user(s) can test too.

biva commented 6 years ago

I just installed NC 14.0.3: is this patch included?

MichaIng commented 6 years ago

@biva I don't think so, can't find the new CookieHelper class inside stable14 branch

criwe commented 6 years ago

@biva @MichaIng I´m not sure, but I think so, because it #11433 is marked as merged and I´ve only made the update to 14.0.3 and no other manual patching.

MichaIng commented 6 years ago

@criwe Jep merged into "master", but not merged into "stable14", which is 14.0.3 branch. But I will test myself now by switching Thunderbird back to network.cookie.same-site.enabled=true

€: Ah lol, it was already... Yeah, I reinstalled Thunderbird in between for some other reason I remember 😆. So somehow the issue seems to be resolved on Thunderbird side already? Also fixing this issue was not the (main) purpose of the PR.

So jep, solved by either another commit until v14.0.2 or on Thunderbird side. @georgehrke To cleanup you can close this issue, as long as nobody complains it is still an issue.

adi-dev commented 6 years ago

Just tried, changed settings network.cookie.same-site.enabled=true and restart the TB and BOOM! my TB version just upgraded to 63 beta 1, none of the add-ons are working lol. Rolled back TB to 60.2.1 (release) and checked, all working with network.cookie.same-site.enabled=true 😃 🍻 cheers guys!


Edit It doesn't work, just realized the TB does not sync events with Nextcloud :cry:

fuzsin commented 6 years ago

Neither Lightning nor CardBook works with Nextcloud 14.0.3 stable without network.cookie.same-site.enabled=false hack. TB 60.2.1 (32-Bit) fresh installed. Additional info: and the Nextcloud is installed in a subdomain in my case.

blackcrack commented 6 years ago

here works with Thunderbird 60.2.1 (32-Bit) with the beta of sogo-connector-60.0.0-e2547a3565.xpi = https://packages.inverse.ca/SOGo/thunderbird/nightly/ calendar works also CardBook works too and my NextCloud is 14.0.3 by the way, the Custom Address Bar in english works also with the v2.5 on github, i have make a version 2.5.1 for German users too and put it on my blackysgate.de/files :) shimamu have the pull request not done for german lang files.. edit: ah ja.. Win7 Modded' hihi

best regards Blacky

screen 00002

jadesoturi commented 6 years ago

The workaround does not work for me.. NextCloud 13.0.7 with Thunderbird 60 x64 on Arch. As soon as i set the setting to FALSE, the calendar gets "disabled" in Lightning and i can reenable it again untill i change the config back to true..

mnlipp commented 6 years ago

For the sake of completeness: The problem still exists with Nextcloud 14.0.3 and TB 60.2.1 (64-Bit) (@fuzsin already reported it for 32-bit). The workaround still works (and is still required).

jadesoturi commented 6 years ago

@mnlipp - I've tried the workaround fix with both the the 32bit and 64bit on my 13.0.7 installation, but it does not work for me. Results in the calendar being turned off in Lightning, until I set the setting to TRUE again. Is there something I'm missing that can be the reason for this?

rullzer commented 6 years ago

I just installed NC 14.0.3: is this patch included?

Nope this is only in master. So will be NC15

abject commented 6 years ago

I use TB60.2.1 (64bits) under Ubuntu 16.04.4 with a Nextcloud 14.0.3 freshly migraded. The change of network.cookie.same-site.enabled=true to network.cookie.same-site.enabled=false allows the calendar synchronisation.

blackcrack commented 6 years ago

NC 14.0.3 on Openmandriva 3.03 Server . Client TB 60.3.0 (32-Bit) https://packages.inverse.ca/SOGo/thunderbird/nightly/ https://packages.inverse.ca/SOGo/thunderbird/nightly/sogo-integrator-60.0.0-3f871d5df1-sogo-demo.xpi this works on TB WinNT and also works the Carddav own solution of Thunderbird.. Open AdressBook => Extra => New => Remote-AdressBook

best regards Blacky

aventustudio commented 6 years ago

I use TB60.2.1 (64bits) under Ubuntu 16.04.4 with a Nextcloud 14.0.3 freshly migraded. The change of network.cookie.same-site.enabled=true to network.cookie.same-site.enabled=false allows the calendar synchronisation.

Thank you! This fixed the issue with Thunderbird 60.3.0. Calendar and Contacts are working now.

qw3ry commented 6 years ago

@jadesoturi the workaround worked for me (mostly fresh Arch installation, Nextcloud 14, don't know which minor version though)

j-ed commented 6 years ago

Unfortunately I ran into a lot of trouble as Thunderbird automatically updates to v60.3.0 (32bits) yesterday. Thunderbird wasn't able to show all my subscribed calendars nor was the response behavior acceptable with network.cookie.same-site.enabled=true, as it tries to synchronize with Nextcloud 14.0.3. I managed to set network.cookie.same-site.enabled=false but the response behavior was still bad although some calendar items were shown. At the end I decided to reinstall Thunderbird 52.9.1 and got everything working again. Therefore it seems that I need to wait for a full fix in Nextcloud to get it working as before.

MichaIng commented 6 years ago

On a fresh Windows install, after network.cookie.same-site.enabled=true was somehow working for me, now it is not anymore, matching reported results here.

Perhaps when Thunderbird and Nextcloud already communicated successfully, cookies are saved and such, the setting can be set to true again? Will test by times.

MikiDi commented 6 years ago

Can confirm this bug for Nextcloud v14.0.3 and Mozilla v60.3.0. The network.cookie.same-site.enabled=false-workaround works. Disabling the setting and re-enabling it after a succesfull sync doesn't help.
When prompted for username and password I get the following warning:
my-hostname is requesting your username and password. WARNING: Your password will not be sent to the website you are currently visiting! What does this mean really? Could this have something to do with the issue?

I understand that a fix in NC 15 is underway (thx!). @rullzer, as you stated

I'm not sure but #11433 might fix this.

Could you elaborate a tiny bit on what you suspect went wrong? If I could help out testing or so I'd be glad to.