nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.71k stars 4k forks source link

Shares icon in high contrast theme #10742

Closed splitt3r closed 6 years ago

splitt3r commented 6 years ago

I activated the high contrast theme and now the shares icon looks like this:

image

I´m running the nextcloud:beta Docker image with MariaDB.

splitt3r commented 6 years ago

With dark mode enabled the arrow icon is black on black:

image

nextcloud-bot commented 6 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/5547 (When sharing "Upload Only" link, have theme background), https://github.com/nextcloud/server/issues/7704 (Icons missing after changing the theming color), https://github.com/nextcloud/server/issues/2277 (Sharing icon seems missing), https://github.com/nextcloud/server/issues/3146 (Theming: contrast improvements for certain color combinations), and https://github.com/nextcloud/server/issues/5157 (Icon inconsistency).

splitt3r commented 6 years ago

The close button in the file select dialog is also not visible:

image

oparoz commented 6 years ago

@skjnldsv - This is what we've talked about. It seems it doesn't work for everybody out of the box.

skjnldsv commented 6 years ago

@oparoz the dark mode is in beta. So we're going to work on it but we're still going to have to grasp the whole compatibility thing with different setup and browsers.

splitt3r commented 6 years ago

All in all it works pretty well already and i like it a lot :) just wanted to share some feedback.

skjnldsv commented 6 years ago

@splitt3r Yes! thanks you very much! :D Keep the feedback coming!

skjnldsv commented 6 years ago

@jancborchardt regarding the opacity hack for the highcontrast theme, should we remove it?