search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.76k stars 4k forks source link

Comment indicator display improvements #11904

Open jancborchardt opened 5 years ago

jancborchardt commented 5 years ago

Currently we only show an uninformative tooltip with "1 unread comment" when you hover the icon. You need to click and open the sidebar for more info: comment text could show directly in tooltip

Instead:

@nextcloud/javascript @nextcloud/designers

nextcloud-bot commented 5 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/pull/10288 (Fix inline avatar display for mentions in comments), https://github.com/nextcloud/server/issues/5691 (Datepicker design improvements), https://github.com/nextcloud/server/issues/2043 (DI Container improvements), https://github.com/nextcloud/server/pull/11522 (Filepicker design improvements), and https://github.com/nextcloud/server/issues/11903 (Comment indicator only shown on list entries without avatar (owned by you)).

juliushaertl commented 5 years ago

The comment text could show directly in the tooltip.

That would just work if there was one unread comment, if there would be more of them, this will quickly get to much information for a popover.

Instead of the simple comment icon, we could show the avatar(s) of the people who commented.

We already show avatars of the share owners in the list view, so I think just having the regular comment icon is quite good here. Otherwise it will get confusing which avatar is about sharing and which is about comments.

jancborchardt commented 5 years ago

That would just work if there was one unread comment, if there would be more of them, this will quickly get to much information for a popover.

We could show the latest one, and then below "3 others by avatars of commenters".

We already show avatars of the share owners in the list view, so I think just having the regular comment icon is quite good here. Otherwise it will get confusing which avatar is about sharing and which is about comments.

That's kind of the point: Basically both of these avatars are the same. Some of them just commented (those are likely shown more prominent). The comment icon would then only be an addition to the avatars. Similar to the notifications design adjustment: https://github.com/nextcloud/notifications/issues/183

And for the grid view we already overlap the comments icon (show it instead of avatars) for lack of space.

MorrisJobke commented 5 years ago

Seems like this also needs to wait for 17.

susnux commented 9 months ago

@jancborchardt are you still behind this? Meaning is this still something that should be implemented?