visual feedback if a note attached to a share was send successfully to the recipient

nextcloud / server

☁️ Nextcloud server, a safe home for all your data

https://nextcloud.com

GNU Affero General Public License v3.0

26.77k stars 4k forks source link

visual feedback if a note attached to a share was send successfully to the recipient #12590

Open schiessle opened 5 years ago

schiessle commented 5 years ago

Right now it is a bit hard to see if a share note was send out correctly. The drop down always looks like this:

How about replacing the arrow with a "sent" confirmation label and only turn it back to an arrow if the user modifies the note? This way you not only get immediately a feedback if the note was sent out correctly but you also see that it was already successfully sent out if you come back to the drop-down a few days later.

cc @nextcloud/designers

nextcloud-bot commented 5 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/11270 ("Note to recipient" API), https://github.com/nextcloud/server/issues/11352 (Send note to recipient: previously content not visible on shared link), https://github.com/nextcloud/server/issues/5658 (share by email - password email not sent - solved), https://github.com/nextcloud/server/issues/9055 (share-internal / calendar-task-note file attached ), and https://github.com/nextcloud/server/issues/3830 (No calendar invitation send for event in shared calendars ).

violoncelloCH commented 5 years ago

didn't you mean "sent" instead of "send"? just to be gramatically correct... otherwise 👍

schiessle commented 5 years ago

@violoncelloch true :wink:

jancborchardt commented 5 years ago

Instead of the text, we could simply show the icon-checkmark: https://docs.nextcloud.com/server/15/developer_manual/design/icons.html

It will always have the same size (also as the confirm icon) and not break depending on language.

szaimen commented 3 years ago

@nextcloud/javascript do you have some pointers? I would then go ahead and create a PR to fix this issue.

juliushaertl commented 3 years ago

https://github.com/nextcloud/server/blob/c8e0809d435e7ad90722be3d8a3304be73d95798/apps/files_sharing/src/components/SharingEntryLink.vue#L271-L285 would be where the input is built but it might require to extend the shared component to give some proper feedback there https://nextcloud-vue-components.netlify.app/#/Components/Actions?id=actiontexteditable

szaimen commented 3 years ago

hm... that's maybe a bit to complicated for me. I though it would already be enough to subsitute the arrow through the checkmark... But thanks for the pointer!