nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.38k stars 4.07k forks source link

displayName not used in the "shared by" Hover #19545

Closed martinhaase closed 4 years ago

martinhaase commented 5 years ago

This is an addendum to https://github.com/nextcloud/user_saml/issues/144, which is not implemented fully yet.

Steps to reproduce

  1. Log in with SAML as User A
  2. Logout
  3. Login in with SAML as User B (ID: ABCDEFGHIJK@insititution.org, DisplayName: "User B")
  4. Create and share some document with User A
  5. Logout
  6. Login as User A

Expected behaviour

When hovering over the Sharing link of this document, I expect "Shared by User B"

Actual behaviour

When hovering over the Sharing link of this document, "Shared by ABCDEFGHIJK@insititution.org" is displayed.

Server configuration

Operating system: Centos 7

Web server: ngingx

Database: MariaDB10.3

PHP version: 7.2

Nextcloud version: (see Nextcloud admin page) 15.05

Where did you install Nextcloud from: official nextcloud site, .ZIP

List of activated apps: SAML authenticaton, Collabora Online,

wiswedel commented 4 years ago

I can confirm this with NC 18.0.1 and user_saml 3.0.1

However this is only on my productive instance with 30.000 users in oc_user_saml_users. My test instance with only one SAML user works just fine.

Maybe this has something to do with the size and some caching? Background jobs are running fine.

Server configuration detail

Operating system: Linux 4.15.0-70-generic nextcloud/user_saml#79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64

Webserver: Apache/2.4.29 (Ubuntu) (apache2handler)

Database: mysql 10.4.8

PHP version: 7.2.24-0ubuntu0.18.04.3

Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, sodium, session, standard, apache2handler, mysqlnd, PDO, xml, apcu, apc, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, igbinary, imagick, intl, json, exif, msgpack, mysqli, pdo_mysql, Phar, posix, readline, redis, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, memcached, Zend OPcache

Nextcloud version: 18.0.1 - 18.0.1.3

Updated from an older Nextcloud/ownCloud or fresh install:

Where did you install Nextcloud from: unknown

Signing status Array ( [files_rightclick] => Array ( [EXTRA_FILE] => Array ( [l10n/fa.js] => Array ( [expected] => [current] => 4c997e86e1f6df2dfea20f2b7b7b29133610a821e7f2d9a8a17f3fdfef9f109b664f4698c853623b90fd06809fe1bba1666ddee1fe5897d0f748e6104b3457d2 ) [l10n/si_LK.json] => Array ( [expected] => [current] => 7290e037a4359d984cbdf505d4098dbe97fffc178624f31047fd653550587438f90c93497f3714adde84bd37bb68ee6ba7765566aecff491fff05c20a90cd466 ) [l10n/zh_HK.json] => Array ( [expected] => [current] => 59b848f5de5ce6f24e774b2daec69d4d06d2958a600b25e92dfe65b1775a7f7ef5b5ec6f76151a5c931f1f64f9cbc546496db26a552b597bc9828742d439e008 ) [l10n/ia.js] => Array ( [expected] => [current] => 6bd91e000bfbbdfc00c80ff460bbaad9003d9239cddb03d3bfd6ea3a94f278df55bc4acb727081554096117369fa530961ae4478668905502ec0cce502184468 ) [l10n/es_NI.json] => Array ( [expected] => [current] => ce5eba277cd43a1665ddfe3b4805525980d62d1a04c7b0353e675c7fcb9b88a026eea5da2d4943b667220487936a1e2d10af4b7fb34a6791694e410ef30bb3bf ) [l10n/ta_LK.js] => Array ( [expected] => [current] => 918b10af8513596c15436eca2fd3363e88d33c651cc8de12ec04911ed2f4a7d36e665f482d113f5b1315483bc313d9c880b0bd30443c212b57f8f414773e2065 ) [l10n/mn.js] => Array ( [expected] => [current] => 22139c7351bebc66aba3fc39a92910ec565bc449bb04b83cc84545f0959179da9522c37e8b7642d4e4082fd5d5498e03e6dd14e14775e8662669edc2bdcfb2a9 ) [l10n/es_CR.js] => Array ( [expected] => [current] => ce80a04696624d6fa28f0bd83aaf6567335a4998c86d45a2a3269b6dd7cfe5e44d748986ce143c997d38cee25e148da12be3ee8b78c1355c7b3fc22d31a8bee4 ) [l10n/be.js] => Array ( [expected] => [current] => d38ef2d3d80a12629f7dfa3831245cf77ad1882691f415f7c27a69963587b47dd10674b454a564f8640ae19a9f00dae330080d220414ba0a969c41d64b41bfd0 ) [l10n/bs.js] => Array ( [expected] => [current] => fee4fbc4d47252b2c59d11306509b56cf3ffaa2b16e8127fe487a389a583f6e4d5fec1d431b258a1e3abb9086c957b347b068badbd82cd3deaca6f1f30c17e56 ) [l10n/bn_BD.json] => Array ( [expected] => [current] => 9a8ddf9af99fa580fad76538e0991d582053d31154e343f36e1bfeaee3f4c66853063a1634463fe07cc88072a670de4d23ae82e64ea72bf80954fc15fee0c370 ) [l10n/ia.json] => Array ( [expected] => [current] => 6358f4cd939498104fb18af7fbadeeacecc89ac7cbccb6cc9d1a44adb0f6bf9d9a36f66325efd92b798617b7bc5b29e825ee223267391fd35820a853b919e764 ) [l10n/cy_GB.json] => Array ( [expected] => [current] => a449c4a570112e1c32047b882a441c958de247276e301a76e85c3c0ed918bd4e24f1338e5d8d7670521e7956603f4e754e51d607a0a7a2e015559274dd377a0c ) [l10n/bs.json] => Array ( [expected] => [current] => 1f910d98707ba7d7c5c8b40834a6268881e73ea3e41aa91e3d5b85de28ab10821451cb5d3e4f746e0307243fe74853c79f5ae8994169ab895d6db8005a443065 ) [l10n/kn.js] => Array ( [expected] => [current] => b8e55e9dfb7ac81f30975faceb7a79ea08a9be8b4fb426e59fdb38eddd1841cd5434f072242bbd2692122ab18e6c5e95d8a6a363c4fa6582f8ae59736ae29d2c ) [l10n/id.js] => Array ( [expected] => [current] => 4ed5a639397675006fd9b442a090283ff79d2bef0b807b55d3657ae1dbcde2ebb74f66dea53220d69f77424a44bb5863e41908efc724188d9e64da41522db356 ) [l10n/mk.json] => Array ( [expected] => [current] => c485189863bff4cd5f028146014ac06437eece371b94aac301c32f76dc8302c8aa6c80ca20b5394cf2ce8785676506a0584f37e1801a4d79ac07f09277442ac9 ) [l10n/ka_GE.json] => Array ( [expected] => [current] => 561a4c3f4b68c744a8e1ecd2b4ef01afc34f82cd534cbaa1fdda98fcb25c6b996571fa2ca4162e10284b88b2b0fdb99ac58b1d2910b6b095d125a8a68f2d4541 ) [l10n/id.json] => Array ( [expected] => [current] => 33c1ce13a98ff9b5c62a80e140d765bc74bba27ba6154c671ae960f25f6dc1f56a5dc92433095660dbf9f32ec458defb14faca6b8d43153d1e40370fbb760ade ) [l10n/uk.js] => Array ( [expected] => [current] => f7fde3253fca2f4590c9c882c1756d1418c867be9f215d2d406ee0b27e169273dff4aa047cfeae4dbd999a170709a01ccee4f910fb01ad7f1f7333bab41d79f5 ) [l10n/ug.js] => Array ( [expected] => [current] => 17fd420e3c994813292b0896b32b22c705852e0c3c00645f04bf4e2b80ca5970e858424c403a9a80db7a9730c8f2a0447d04caebd02beeda6cb03b1cd51cafd4 ) [l10n/nn_NO.js] => Array ( [expected] => [current] => 3993bc8c00d37c0d8e41244c2cf8743bd79e18809e162bed6f777d9a3aafc8e7e5401b84b5dd1935218b1374a8570cc43ac21a8083cb5f3b4bcb58ecf3976bc6 ) [l10n/ka_GE.js] => Array ( [expected] => [current] => 47f1b46c0965c719862aa59c5e9e6a2fb23f3070cd5e2de5558ac060f4717a9bb846a8e5b03daefa8e6b1f5accd57347f243c8258f1818d4f8200037ea389a76 ) [l10n/sq.js] => Array ( [expected] => [current] => 312c82875f4dc11105cd87db46416058d927a6fcc04ddb52872a6b380c168f4c86232d2c6c22fa0019350ce92949e0d4621421e32c55c0e7b3e29f705d79248c ) [l10n/ast.json] => Array ( [expected] => [current] => 55a40b5a983479603a0d010d366247965967befa986e4e6f6355aeb47d3c371c2ba26d548adabca5dab3e53e7a3573092cc1fa80351e97a6812bc9ea9ea6ca4d ) [l10n/nn_NO.json] => Array ( [expected] => [current] => 5096b3c4f3a16699fb6c8b171f040747ed4afbb46cf6afbf8f0e149cb440b5795e32c2124fe227fadca9d3bf66bf32aa495a3acec38ff5ad7eb30d93d5b3a700 ) [l10n/mk.js] => Array ( [expected] => [current] => e8b23062ec174a61470eb3da031efd5f7400ee8d914194cd74b68d69c2836df34b5fcb79406980caadb8e48dc73452d2c1a265042dfe9653de42226edd3b17d0 ) [l10n/ast.js] => Array ( [expected] => [current] => d1004cc2088c6cf80b1c345d391ad5865802f1a3612544d44a1cb95823774d1f1eddca3dd370c7f6189e712823aa79ff66da8db05f7ed5caa5b27fb18106dd5a ) [l10n/uk.json] => Array ( [expected] => [current] => 28983e0c85b236418e270c115cc90c0c7290f6db09466ea2d5738447ec82f5f7240a899fcf05b2866ad789b88c021dbc264d0db3606c59744160ddfc7881a2e5 ) [l10n/oc.json] => Array ( [expected] => [current] => 2e2aa5e970b869966c46d3d778de4f5b790454bb2a9d6b11aed6e1908744ae9e0499f7e95244f122a37ec71baa1180d37a1dc8a95b703f34cb3bce74c0913c80 ) [l10n/et_EE.js] => Array ( [expected] => [current] => 07204f874ab7f2f239b01aa122175207b21996ad1f6b9240e7fa456144946d95d22f7ba6bf0cdf92e839c3a9b791c19e293dea487868e06e3a8e540207c2db19 ) [l10n/af.json] => Array ( [expected] => [current] => 47338b6b66bc4581e5691b3625dc2a02375ddfbeafbafd9751f67de74741d45fccb62426d65f5d7790552234718256b42852c2b4e77cf56b6bf09c233bebd34c ) [l10n/ro.js] => Array ( [expected] => [current] => 42daef172e0bbd273540d07812dcd1d5bf52929539abcb797b176b81226522125394220fc2c10dfdac093a31b9f0dffc0ed4a76a93eb12686703dab2a56c36bd ) [l10n/hr.json] => Array ( [expected] => [current] => e86dc9dea18d1f90dbc8336119fe9a91d89da5de5323d50761957e5e97b27ef1891e74eef52ff3ce9c61260f55571028480fea8a26a08f11388166c95b7a18b6 ) [l10n/fa.json] => Array ( [expected] => [current] => 6cc98308f96d8de5675ec3a08a51479c72dfa1c4bfb6a7e14b8a6def726f540d46b89aa41685b669b73f6fa893f6baf79afcb91d1e510f21126b9b968a5cfb46 ) [l10n/be.json] => Array ( [expected] => [current] => 4b5f93b8302c627664105dc9b675f736b70e1a03c472e7776b1931bf3247cf041ae0088b3c79cd429194e904558854bd9f7b987e6d003de98bbe16f63f0b5e97 ) [l10n/bn_BD.js] => Array ( [expected] => [current] => 1247727bb3ca089d6aed2256d584258401a53ae6028b37b0b9bc66d29b6819cb77762aa42838058b8ea1d9a3dd09942118669ead72e5bc2fb424a395dd2905b9 ) [l10n/sq.json] => Array ( [expected] => [current] => 63e1b5a747fad57fbfc30fef4a93f07fd82625a55c0f29d4798bc9bf5f4926463be731055b218bfd9018627ff363b53a344284554af0585d431da1cf9961d288 ) [l10n/eu.js] => Array ( [expected] => [current] => e4e301f4d2c1b225c8b6ea4ad4dd28cde6af998a4c043eb95cc0e019af04fcfb711b573042c28ea3b9ff7b051935b0ae881b1dc2c3d8bda2503ce83d9a614a30 ) [l10n/mn.json] => Array ( [expected] => [current] => ec3e320649913dcf65eb57a21d015109f1128ffea08b384ab5f1fa6ebddd90568a9b6cb72ae0ca5753a704b32e951a4cb94c28af295e6fabcbcf1425d157c267 ) [l10n/ro.json] => Array ( [expected] => [current] => 215e40111cdbeacf9ded4da9473410850452e4d807ae74842d1af15f06b1355ce2bb7a65dc04457e0ce7ab890056e5f96e88e9eff9c5fe3dac7898b12f3b22f3 ) [l10n/hr.js] => Array ( [expected] => [current] => a2acbc22e721d3b172b7dec826b1e5a64560d5ebb7c5f20f10b18451958e0cd17fb88a5015e619f0127155e62c8106568f77ec6ac192993f633c5a42733dcc6b ) [l10n/et_EE.json] => Array ( [expected] => [current] => 1d3e943ea8176dc21dc45fadcd1a0b34e4931a3515310ce03fa3bc5dcb7ac54593bf026a32f07823935b0ffeae9d4f10c1573f2cbc53d362ca5842cbfcae6566 ) [l10n/cy_GB.js] => Array ( [expected] => [current] => 3c7ceedf33186b9d74b15d0a3e69ed5197405d067e14883d439362273b7e55caf5513a2d19dee4019e4dd19b76ad6f423dfba92bcd59a9a87c2889a1cd5daf0a ) [l10n/eu.json] => Array ( [expected] => [current] => cb6dc1a02f85422339608dcebd5a0ec6524d3252100820059b604b1cf5387f1b6a7000862779c7e97eb580ca4853bcdf0eba211fe1258d920165745ded14099e ) [l10n/af.js] => Array ( [expected] => [current] => c7916382d8c1a4bf8bd2562085e692d25c1d7d9ec250e95baf61dd7589496c37137352fde053942b85417742d17a0e6d565281e735ca8a6f487b37d13a7ed1ae ) [screenshots/picture.png] => Array ( [expected] => [current] => e568eb7f50fb5cf8eac8ebd8d3c7833ca75f88682de46292edc14f67fac6117e82ef392fc2e069c22ddca545f3fe938f03a162454b8e1877d98d224ba5160f8e ) [screenshots/file.png] => Array ( [expected] => [current] => a5334d1853939971aa27543dc0b0d55ce01eb9674695133d6be6141383486daf961cc865d1f10317cf47edda42af6cbc0ca8975ea6778fb0d9ee7682f90da092 ) [screenshots/folder.png] => Array ( [expected] => [current] => 200cc50fb067d9f589c26636d2aba1f639750012743ec5b749fae86f19628e27cb0fbb910ea795862daea0a9717be691307fd4627bccc33249525a8e562a57f2 ) ) ) )
List of activated apps Enabled: - accessibility: 1.4.0 - activity: 2.11.0 - bruteforcesettings: 1.5.0 - cloud_federation_api: 1.1.0 - comments: 1.8.0 - dav: 1.14.0 - federatedfilesharing: 1.8.0 - federation: 1.8.0 - files: 1.13.1 - files_automatedtagging: 1.8.0 - files_external: 1.9.0 - files_pdfviewer: 1.7.0 - files_retention: 1.7.0 - files_rightclick: 0.15.1 - files_sharing: 1.10.1 - files_trashbin: 1.8.0 - files_versions: 1.11.0 - files_videoplayer: 1.7.0 - firstrunwizard: 2.7.0 - guests: 1.4.1 - impersonate: 1.5.0 - logreader: 2.3.0 - lookup_server_connector: 1.6.0 - nextcloud_announcements: 1.7.0 - notifications: 2.6.0 - oauth2: 1.6.0 - password_policy: 1.8.0 - photos: 1.0.0 - privacy: 1.2.0 - provisioning_api: 1.8.0 - recommendations: 0.6.0 - serverinfo: 1.8.0 - settings: 1.0.0 - sharebymail: 1.8.0 - support: 1.1.0 - survey_client: 1.6.0 - systemtags: 1.8.0 - text: 2.0.0 - theming: 1.9.0 - twofactor_backupcodes: 1.7.0 - updatenotification: 1.8.0 - user_saml: 3.0.1 - user_usage_report: 1.2.0 - viewer: 1.2.0 - workflowengine: 2.0.0 Disabled: - admin_audit - encryption - files_fulltextsearch - files_fulltextsearch_tesseract - fulltextsearch - fulltextsearch_elasticsearch - user_ldap
Configuration (config/config.php) { "app_install_overwrite": [ "groupfolders", "external", "files_automatedtagging", "files_retention", "files_rightclick" ], "share_folder": "\/Shares", "skeletondirectory": "\/path\/to\/skeleton", "loglevel": 2, "log_rotate_size": 26214400, "logdateformat": "F d, Y H:i:s", "logtimezone": "Europe\/Berlin", "default_locale": "de_DE", "default_language": "de", "htaccess.RewriteBase": "\/", "simpleSignUpLink.shown": false, "trashbin_retention_obligation": "auto, 7", "part_file_in_storage": false, "sort_groups_by_name": true, "auth.bruteforce.protection.enabled": true, "blacklisted_files": [ ".htaccess", "Thumbs.db", "thumbs.db" ], "preview_max_x": 1024, "preview_max_y": 768, "preview_max_scale_factor": 1, "enable_previews": true, "enabledPreviewProviders": [ "OC\\Preview\\BMP", "OC\\Preview\\GIF", "OC\\Preview\\HEIC", "OC\\Preview\\JPEG", "OC\\Preview\\MarkDown", "OC\\Preview\\MP3", "OC\\Preview\\PNG", "OC\\Preview\\TXT", "OC\\Preview\\XBitmap", "OC\\Preview\\Illustrator", "OC\\Preview\\Movie", "OC\\Preview\\MSOffice2003", "OC\\Preview\\MSOffice2007", "OC\\Preview\\MSOfficeDoc", "OC\\Preview\\OpenDocument", "OC\\Preview\\PDF", "OC\\Preview\\Photoshop", "OC\\Preview\\Postscript", "OC\\Preview\\StarOffice", "OC\\Preview\\SVG", "OC\\Preview\\TIFF", "OC\\Preview\\Font" ], "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "25", "mail_domain": "***REMOVED SENSITIVE VALUE***", "maintenance": false, "log_type": "file", "theme": "", "updater.release.channel": "stable", "memcache.local": "\\OC\\Memcache\\APCu", "memcache.distributed": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "redis.cluster": { "seeds": [ "1***REMOVED SENSITIVE VALUE***0:7000", "1***REMOVED SENSITIVE VALUE***0:7001", "1***REMOVED SENSITIVE VALUE***1:7000", "1***REMOVED SENSITIVE VALUE***1:7001", "1***REMOVED SENSITIVE VALUE***2:7000", "1***REMOVED SENSITIVE VALUE***2:7001" ], "timeout": 0, "read_timeout": 0, "failover_mode": 1 }, "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "***REMOVED SENSITIVE VALUE***", "***REMOVED SENSITIVE VALUE***" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "18.0.1.3", "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true }

External storages: yes

External storage configuration No mounts configured

Encryption: no

User-backends:

OC\User\Database

OCA\Guests\UserBackend

OCA\User_SAML\UserBackend

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36

wiswedel commented 4 years ago

image

juliusknorr commented 4 years ago

This actually seems to be unrelated to saml but to the userid containing an @ symbol and therefore matching the regex for federated user ids. https://github.com/nextcloud/server/blob/f8a36630e7289864425603b57576cf05118ad18c/apps/files_sharing/src/share.js#L352

Moving to the server repo.