search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.37k stars 4.07k forks source link

Warn if apps use the view #1987

Open rullzer opened 8 years ago

rullzer commented 8 years ago

See discussion in https://github.com/nextcloud/server/pull/1233

Apps should not use private classes. We should start warning in the code checker and maybe even the logs. Apps should use the Node API. And if stuff is missing from there we should invest time in adding that functionality.

The node API was introduced ~3 years ago. So I'd say apps should migrate ASAP!

CC: @icewind1991 @nickvergessen

MariusBluem commented 8 years ago

Maybe we should also add this as a policy for apps published over our appstore 🤔 @BernhardPosselt

BernhardPosselt commented 8 years ago

@MariusBluem nope, definitely not a goal there. The last thing that we want is to run a PHP parser over abitrary code.

nickvergessen commented 8 years ago

No, also the Node API is not always suitable atm.

BernhardPosselt commented 8 years ago

Isn't this already integrated into core btw :D?

Maybe the way to go is to just modify the default .travis.yml like this https://github.com/nextcloud/news/blob/master/.travis.yml#L48

szaimen commented 3 years ago

I suppose this issue is still valid? If not, please close this issue!

nickvergessen commented 3 years ago

Yeah it's still heavily used as the node api doesn't allow to do all/the same things the view can