nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.31k stars 4.06k forks source link

Exported groups are badly formatted - import not possible in thunderbird #23250

Closed olivy70 closed 3 years ago

olivy70 commented 4 years ago

Hey !

The problem is when I export a Group to import it in thunderbird. The import generates an error "Error importing addresses from Vcard file".

I have noticed that sometimes there is a problem with the BEGIN / END of some Vcards. The BEGIN and the END are on the same line, and it generates the import error.

ex: BEGIN:VCARD FN:Les affiches de la Haute-Saone UID:0b5ca12e-96dd-4d3c-8aa8-f059048a5a9b TEL;TYPE=VOICE:0633513887 EMAIL;TYPE=WORK:email@orange.fr CATEGORIES:diffusion-presse VERSION:3.0 N: ;;;; END:VCARDBEGIN:VCARD --------------------------------------------------->problem FN:Vosges FM UID:bba054a4-eee0-48e2-a7eb-56bb3066ab72 EMAIL;TYPE=WORK:email@gmail.com CATEGORIES:diffusion-presse VERSION:3.0 N: ;;;; END:VCARD

Expected behaviour

BEGIN:VCARD ... END:VCARD BEGIN:VCARD ... END:VCARD

Actual behaviour

BEGIN:VCARD ... END:VCARDBEGIN:VCARD ... END:VCARD

Server configuration detail

Operating system: Ubuntu

Webserver: nginx

Nextcloud version: 19.0.2

skjnldsv commented 4 years ago

Hum, they are properly separated by a new line for me. But there might be an issue with End-of-line compatibility.

I will need a screenshot of your network requests. Before you do anything, still on the development tools, there is a tab called network. Click on it and then the xhr filter. Do the export and screenshot the network log like this: Capture d’écran_2020-10-06_18-01-07

I'm specifically looking for the ?export request. Please check the response tab and see if you can spot the missing new line in the request directly.

olivy70 commented 4 years ago

Hum, they are properly separated by a new line for me. But there might be an issue with End-of-line compatibility.

I will need a screenshot of your network requests. Before you do anything, still on the development tools, there is a tab called network. Click on it and then the xhr filter. Do the export and screenshot the network log like this: Capture d’écran_2020-10-06_18-01-07

I'm specifically looking for the ?export request. Please check the response tab and see if you can spot the missing new line in the request directly.

Here is the screenshot.

image

skjnldsv commented 4 years ago

Okay, this needs a fix in server then :+1:

j-ed commented 4 years ago

@skjnldsv Interesting, this problem should already have been fixed with NC 18, based on this issue ticket.

skjnldsv commented 4 years ago

Let's add two more lines? xD

olivy70 commented 4 years ago

I add that there is no problem with the export of an address book. Only with groups.