nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.89k stars 4.02k forks source link

Web updater 18.0.10 to 18.0.11 does nothing #24322

Closed bluikko closed 3 years ago

bluikko commented 3 years ago

How to use GitHub

Steps to reproduce

  1. Open updater from Admin user "Settings" -> "Overview" -> "Open updater" image

  2. The update screen opens as normal -> click "Continue update" image

  3. The updater jumps immediately to the end and does nothing image

Expected behaviour

At step 3 it should go through the steps "Initializing", " Check for expected files", "Check for write permissions", ... etc.

And actually do the update to 18.0.11.

Actual behaviour

Updater jumps immediately to the end and doesn't seem to do anything.

Can only click on "Go back to your Nextcloud instance to finish the update" that usually is clicked after update is finished.

Server configuration

Operating system: CentOS7 7.9.2009

Web server: Apache 2.4

Database: MySQL 5.7.31 with Galera 3

PHP version: 7.3.24

Nextcloud version: (see Nextcloud admin page) 18.0.10

Updated from an older Nextcloud/ownCloud or fresh install: Yes, updated several times from Nextcloud 13 or so.

Where did you install Nextcloud from: .tar.gz

Signing status:

Signing status ``` No errors have been found. ```

List of activated apps:

App list ``` Enabled: - accessibility: 1.4.0 - activity: 2.11.1 - admin_audit: 1.8.0 - cloud_federation_api: 1.1.0 - comments: 1.8.0 - contacts: 3.4.0 - dav: 1.14.0 - federatedfilesharing: 1.8.0 - files: 1.13.1 - files_pdfviewer: 1.7.0 - files_rightclick: 0.15.2 - files_sharing: 1.10.1 - files_trashbin: 1.8.0 - files_versions: 1.11.0 - files_videoplayer: 1.7.0 - firstrunwizard: 2.7.0 - logreader: 2.3.0 - lookup_server_connector: 1.6.0 - nextcloud_announcements: 1.7.0 - notifications: 2.6.0 - oauth2: 1.6.0 - password_policy: 1.8.0 - photos: 1.0.0 - privacy: 1.2.0 - provisioning_api: 1.8.0 - quota_warning: 1.7.0 - recommendations: 0.6.0 - serverinfo: 1.8.0 - settings: 1.0.0 - sharebymail: 1.8.0 - support: 1.1.1 - survey_client: 1.6.0 - systemtags: 1.8.0 - text: 2.0.0 - theming: 1.9.0 - twofactor_backupcodes: 1.7.0 - updatenotification: 1.8.0 - user_ldap: 1.8.1 - viewer: 1.2.0 - workflowengine: 2.0.0 ```

Nextcloud configuration:

Config report ``` { "system": { "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": { "1": "localhost", "2": "cloud.x.com", "3": "cloud01.x.com" }, "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "18.0.10.2", "overwrite.cli.url": "https:\/\/cloud.x.com", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "instanceid": "***REMOVED SENSITIVE VALUE***", "ldapIgnoreNamingRules": false, "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory", "updater.release.channel": "stable", "maintenance": false, "loglevel": 2, "default_locale": "en_GB", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "skeletondirectory": "", "tempdirectory": "\/data\/nextcloud\/tmp", "trashbin_retention_obligation": "auto, 14", "simpleSignUpLink.shown": false, "knowledgebaseenabled": false, "allow_user_to_change_display_name": false, "memcache.local": "\\OC\\Memcache\\Memcached", "memcached_servers": [ [ "\/var\/run\/memcached\/memcached.socket", 0 ] ], "updater.secret": "***REMOVED SENSITIVE VALUE***" }, "apps": { "accessibility": { "enabled": "yes", "installed_version": "1.4.0", "types": "" }, "activity": { "enabled": "yes", "installed_version": "2.11.1", "notify_email_calendar": "0", "notify_email_calendar_event": "0", "notify_email_calendar_todo": "0", "notify_email_comments": "1", "notify_email_favorite": "0", "notify_email_file_changed": "0", "notify_email_file_created": "0", "notify_email_file_deleted": "0", "notify_email_file_restored": "0", "notify_email_public_links": "0", "notify_email_remote_share": "0", "notify_email_shared": "1", "notify_email_systemtags": "0", "notify_setting_batchtime": "3600", "notify_setting_self": "1", "notify_setting_selfemail": "0", "notify_stream_calendar": "1", "notify_stream_calendar_event": "1", "notify_stream_calendar_todo": "1", "notify_stream_comments": "1", "notify_stream_favorite": "1", "notify_stream_file_changed": "1", "notify_stream_file_created": "1", "notify_stream_file_deleted": "1", "notify_stream_file_favorite": "0", "notify_stream_file_restored": "1", "notify_stream_public_links": "1", "notify_stream_remote_share": "1", "notify_stream_shared": "1", "notify_stream_systemtags": "1", "types": "filesystem" }, "admin_audit": { "enabled": "yes", "installed_version": "1.8.0", "types": "logging" }, "backgroundjob": { "lastjob": "67835" }, "calendar": { "enabled": "no", "installed_version": "1.7.0", "types": "" }, "cloud_federation_api": { "enabled": "yes", "installed_version": "1.1.0", "types": "filesystem" }, "comments": { "enabled": "yes", "installed_version": "1.8.0", "types": "logging" }, "contacts": { "enabled": "yes", "installed_version": "3.4.0", "types": "filesystem" }, "core": { "backgroundjobs_mode": "cron", "enterpriseLogoChecked": "yes", "installedat": "1537612860.3705", "lastcron": "1606200318", "lastupdateResult": "{\"version\":\"18.0.11.2\",\"versionstring\":\"Nextcloud 18.0.11\",\"url\":\"https:\\\/\\\/download.nextcloud.com\\\/server\\\/releases\\\/nextcloud-18.0.11.zip\",\"web\":\"https:\\\/\\\/docs.nextcloud.com\\\/server\\\/18\\\/admin_manual\\\/maintenance\\\/upgrade.html\",\"changes\":\"https:\\\/\\\/updates.nextcloud.com\\\/changelog_server\\\/?version=18.0.11\",\"autoupdater\":\"1\",\"eol\":\"0\"}", "lastupdatedat": "1606200353", "oc.integritycheck.checker": "[]", "public_files": "files_sharing\/public.php", "public_webdav": "dav\/appinfo\/v1\/publicwebdav.php", "scss.variables": "19a870cf0756dad479442dd20dad29e5", "shareapi_allow_resharing": "no", "shareapi_enable_link_password_by_default": "yes", "shareapi_enforce_links_password": "yes", "theming.variables": "50ef850c7993f530c35be7378d4e1f1a", "updater.secret.created": "1606200548", "vendor": "nextcloud" }, "dav": { "buildCalendarReminderIndex": "yes", "buildCalendarSearchIndex": "yes", "chunks_migrated": "1", "enabled": "yes", "generateBirthdayCalendar": "no", "installed_version": "1.14.0", "regeneratedBirthdayCalendarsForYearFix": "yes", "types": "filesystem" }, "federatedfilesharing": { "enabled": "yes", "installed_version": "1.8.0", "types": "" }, "federation": { "enabled": "no", "installed_version": "1.4.0", "types": "authentication" }, "files": { "cronjob_scan_files": "500", "enabled": "yes", "installed_version": "1.13.1", "types": "filesystem" }, "files_pdfviewer": { "enabled": "yes", "installed_version": "1.7.0", "types": "" }, "files_rightclick": { "enabled": "yes", "installed_version": "0.15.2", "types": "" }, "files_sharing": { "enabled": "yes", "incoming_server2server_share_enabled": "no", "installed_version": "1.10.1", "lookupServerUploadEnabled": "no", "outgoing_server2server_share_enabled": "no", "types": "filesystem" }, "files_texteditor": { "enabled": "no", "installed_version": "2.8.0", "types": "" }, "files_trashbin": { "enabled": "yes", "installed_version": "1.8.0", "types": "filesystem,dav" }, "files_versions": { "enabled": "yes", "installed_version": "1.11.0", "types": "filesystem,dav" }, "files_videoplayer": { "enabled": "yes", "installed_version": "1.7.0", "types": "" }, "firstrunwizard": { "enabled": "yes", "installed_version": "2.7.0", "types": "logging" }, "gallery": { "enabled": "no", "installed_version": "18.4.0", "types": "" }, "logreader": { "enabled": "yes", "installed_version": "2.3.0", "types": "" }, "lookup_server_connector": { "enabled": "yes", "installed_version": "1.6.0", "types": "authentication" }, "nextcloud_announcements": { "enabled": "yes", "installed_version": "1.7.0", "pub_date": "Thu, 24 Oct 2019 00:00:00 +0200", "types": "logging" }, "notifications": { "enabled": "yes", "installed_version": "2.6.0", "types": "logging" }, "oauth2": { "enabled": "yes", "installed_version": "1.6.0", "types": "authentication" }, "password_policy": { "enabled": "yes", "enforceNonCommonPassword": "0", "installed_version": "1.8.0", "types": "" }, "photos": { "enabled": "yes", "installed_version": "1.0.0", "types": "" }, "privacy": { "enabled": "yes", "installed_version": "1.2.0", "types": "" }, "provisioning_api": { "enabled": "yes", "installed_version": "1.8.0", "types": "prevent_group_restriction" }, "quota_warning": { "alert_email": "yes", "alert_percentage": "99", "enabled": "yes", "installed_version": "1.7.0", "plan_management_url": "", "types": "filesystem", "warning_email": "yes", "warning_percentage": "95" }, "recommendations": { "enabled": "yes", "installed_version": "0.6.0", "types": "" }, "serverinfo": { "enabled": "yes", "installed_version": "1.8.0", "types": "" }, "settings": { "enabled": "yes", "installed_version": "1.0.0", "types": "" }, "sharebymail": { "enabled": "yes", "enforcePasswordProtection": "yes", "installed_version": "1.8.0", "types": "filesystem" }, "support": { "SwitchUpdaterServerHasRun": "yes", "enabled": "yes", "installed_version": "1.1.1", "types": "session" }, "survey_client": { "enabled": "yes", "installed_version": "1.6.0", "types": "" }, "systemtags": { "enabled": "yes", "installed_version": "1.8.0", "types": "logging" }, "text": { "enabled": "yes", "installed_version": "2.0.0", "types": "dav" }, "theming": { "cachebuster": "4", "enabled": "yes", "installed_version": "1.9.0", "name": "CorpX Cloud", "slogan": "***REMOVED SENSITIVE VALUE***", "types": "logging", "url": "***REMOVED SENSITIVE VALUE***" }, "twofactor_backupcodes": { "enabled": "yes", "installed_version": "1.7.0", "types": "" }, "updatenotification": { "calendar": "1.7.1", "contacts": "3.4.2", "core": "18.0.11.2", "enabled": "yes", "files_rightclick": "0.15.1", "installed_version": "1.8.0", "types": "", "update_check_errors": "0" }, "user_ldap": { *snip* }, "user_saml": { "enabled": "no", "general-allow_multiple_user_back_ends": "1", "general-require_provisioned_account": "0", "general-uid_mapping": "REMOTE_USER", "installed_version": "2.3.1", "type": "environment-variable", "types": "authentication" }, "viewer": { "enabled": "yes", "installed_version": "1.2.0", "types": "" }, "workflowengine": { "enabled": "yes", "installed_version": "2.0.0", "types": "filesystem" } } } ```

Are you using external storage, if yes which one: local/smb/sftp/... GlusterFS

Are you using encryption: yes/no No

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/... AD

LDAP configuration (delete this part if not used)

LDAP config ``` I don't think this is relevant ```

Client configuration

Browser: Both Chrome Windows and Edge latest versions tested.

Operating system: Windows 10

Logs

Web server error log

Web server error log ``` no errors ```

Nextcloud log (data/nextcloud.log)

Nextcloud log ``` The log file is 300 MB... Nothing is logged when clicking "Continue update" ```

Browser log

Browser log ``` not relevant? ```
skjnldsv commented 3 years ago

As this seems to be a setup issue I would like to ask you to raise your question in the forums: https://help.nextcloud.com

bluikko commented 3 years ago

Interesting. The setup was last changed many updates ago.

skjnldsv commented 3 years ago

I'll also suggest you upgrade to 20 ;)

bluikko commented 3 years ago

The updater only offers 18.0.11. I am not interested in using time to manually upgrade until I have to, especially when 19 was such a short-lived major version without any interesting features.

edit: I wonder how did you come to the conclusion that it is a "setup issue". If you are talking about the "warning" about MySQL 4-byte support - that is simply a warning and I am not interested in manual changes just to support "emojis in comments". The warning itself lists that it is simply a "recommendation".

skjnldsv commented 3 years ago

What about bugfixes and security upgrades? :sweat_smile:

skjnldsv commented 3 years ago

edit: I wonder how did you come to the conclusion that it is a "setup issue".

Because I tested the upgrade on a standard default nextcloud and it worked just fine (also, we have automated testing for those kind of stuff)

Have you tried command line upgrade?

bluikko commented 3 years ago

18 is listed as a supported branch. So I expect it to have important issues fixed just like in 20.

bluikko commented 3 years ago

edit: I wonder how did you come to the conclusion that it is a "setup issue".

Because I tested the upgrade on a standard default nextcloud and it worked just fine (also, we have automated testing for those kind of stuff)

Thank you for your time to reply. Nothing more can be said after this.

skjnldsv commented 3 years ago

Have you tried command line upgrade?

bluikko commented 3 years ago

Same problem going from 18.0.10 to 18.0.12 or 18.0.13 and the command line updater.phar has the exact same behavior: all update steps are executed in a blink of the eye and message Update of code successful. is displayed with no actual changes happening.

This system has been updated several times in the past without issues, initially from 14.0.0.

2021-01-22T01:49:09+0000 dbm7GH8qUm [info] updater cli is executed
2021-01-22T01:49:09+0000 dbm7GH8qUm [info] currentStep()
2021-01-22T01:49:09+0000 dbm7GH8qUm [info] Step 12 is in state "end".
2021-01-22T01:49:09+0000 dbm7GH8qUm [info] current version: 18.0.10 build time: 2020-10-08T07:23:34+00:00 e61ac0275c791d178c720df320e4a4750172d761
2021-01-22T01:49:09+0000 dbm7GH8qUm [info] getUpdateServerResponse()
2021-01-22T01:49:09+0000 dbm7GH8qUm [info] updaterServer: https://updates.nextcloud.com/updater_server/
2021-01-22T01:49:09+0000 dbm7GH8qUm [info] releaseChannel: stable
2021-01-22T01:49:09+0000 dbm7GH8qUm [info] internal version: 18.0.10.2
[...]
2021-01-22T01:49:23+0000 dbm7GH8qUm [info] updater started
2021-01-22T01:49:23+0000 dbm7GH8qUm [info] update of code successful.
bluikko commented 3 years ago

A message was sent to the community forum 2 months ago with only 1 reply about trying the command line updater. I still posit this is a bug. My configuration has not changed since the previous updates which worked.

I guess it needs to be re-installed then, maybe in 2022 judging by the current workload.

bluikko commented 3 years ago

Success!! occ maintenance:repair fixed something and now the updater is working finally.

Edit: The issue might have been this:

 - Move .step file of updater to backup location
     - .step file exists
     - .step-previous-update removed
     - .step file moved to .step-previous-update

Looks like there was some leftovers from some update.

And while looking at this issue, the sheer amount of issues about update errors kinda proves that the bold statement in https://github.com/nextcloud/server/issues/24322#issuecomment-733494361 is... "optimistic".