Open blizzz opened 3 years ago
Confirmation via link is required.
Will this close https://github.com/nextcloud/server/issues/15373, too? Meaning all email address changes need to be verified, not just adding additional ones?
Linking it here as a reference/reminder to close it afterwards.
Confirmation via link is required.
Will this close #15373, too? Meaning all email address changes need to be verified, not just adding additional ones?
Linking it here as a reference/reminder to close it afterwards.
For now it is only additional addresses. User backend addresses are not always writable and may be provided directly by the user backend. If a looup server (something like a global addressbook) is being used, it will actually cause a confirmation (since it does not trust the provided data). Nevertheless, I see the use case for confirming those as well, when users are able to change it. It's not in scope here, maybe it can be dealt with as by-catch, but no promises.
If I could make a humble request: For me it would be also important, that the calendar recognizes also the multiple email addresses. E.g. there are two email-addresses for each user: userid@domain (internal for login) and firstname.lastname@domain (official). If you would invite with the "official email address" and the user clicks the "accept" button, the meeting is not added in your calendar, as the calendar app does not recognize the second email address. Thank you.
Allow users to set multiple email addresses, and select one as primary address. Confirmation via link is required. Additional addresses are being considered in e.g. share dialogues.
[x] \OC(P)\Accounts\ components are extended to support multi-value properties in general and emails in particular https://github.com/nextcloud/server/pull/27189
[x] \OCA\Settings\Controller\UsersController methods are discontinued in favor of User Provisining API. Currently they exist in parallel. The User Provisioning API has to be extended accordingly https://github.com/nextcloud/server/pull/27474
[ ] \OCA\DAV\CardDAV\Converter::createCardFromUser has to be extended to support additional multiple values
[x] Mail verification has to be implemented (following the password reset, same mechanisms) – part of https://github.com/nextcloud/server/pull/28422
[x] coniguration option for setting notification mails and UI controls – https://github.com/nextcloud/server/pull/28422 and https://github.com/nextcloud/server/pull/28840
[ ] Email uniquness cannot be guaranteed through DB structure (for they are not unique and would potentially break setups). It is ensured when creating and verifying additional email addresses.
[ ] occ commands for adding and removing mails; and making one primary
[x] Frontend email section in Vue with Integration https://github.com/nextcloud/server/pull/27379
[ ] Preserve order and scope of additional emails