search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.75k stars 4k forks source link

Export comments js as dedicated `@nextcloud/comments` lib #27054

Open skjnldsv opened 3 years ago

skjnldsv commented 3 years ago

https://github.com/nextcloud/server/blob/d89a75be0b01f0423a7c1ad2d58aac73c3cc1f3a/lib/private/Comments/Manager.php#L1306-L1309 https://github.com/nextcloud/server/blob/d89a75be0b01f0423a7c1ad2d58aac73c3cc1f3a/apps/comments/src/comments-app.js#L23

Announcement center is using it, so is deck. It make sense to have this as a dedicated lib so people can import it directly as a vue component

https://github.com/nextcloud/announcementcenter/blob/0a2058157f8382dd1fb7c562a1c15c2323e127f4/src/App.vue#L139

cc @juliushaertl @nickvergessen

juliushaertl commented 3 years ago

So is deck.

:open_mouth: Where? I don't remember anything and cannot find a reference.

However fully agree that the global view should be something we deprecated and rather have a shared component/library for.

nickvergessen commented 3 years ago

Where? I don't remember anything and cannot find a reference.

Oh I thought that is where I copied it from 🤔

juliushaertl commented 3 years ago

Might have been in the angular version before the vue rewrite