nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.46k stars 4.08k forks source link

[22.0.0 beta3] Deprecated event type for OCP\IDBConnection::CHECK_MISSING_COLUMNS #27404

Closed MichaIng closed 3 years ago

MichaIng commented 3 years ago

How to use GitHub

Steps to reproduce

  1. Upgrade to Nexcloud 22.0.0 beta3
  2. Visit the admin panel to trigger setup checks
  3. View logs

Expected behaviour

The setup checks do not produce logs.

Actual behaviour

{"reqId":"ZEPRH9ileZIAeEbemRwj","level":1,"time":"2021-06-06T12:58:24+02:00","remoteAddr":"2a01:c22:a440:6700:a851:5eab:17b1:52ec","user":"Micha","app":"no app in context","method":"GET","url":"/nextcloud/settings/ajax/checksetup","message":"Deprecated event type for OCP\\IDBConnection::CHECK_MISSING_COLUMNS: Symfony\\Component\\EventDispatcher\\GenericEvent is used","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4484.7 Safari/537.36 OPR/78.0.4072.0 (Edition developer)","version":"22.0.0.6","id":"60bcaa5b29d2f"}
{"reqId":"ZEPRH9ileZIAeEbemRwj","level":1,"time":"2021-06-06T12:58:22+02:00","remoteAddr":"2a01:c22:a440:6700:a851:5eab:17b1:52ec","user":"Micha","app":"no app in context","method":"GET","url":"/nextcloud/settings/ajax/checksetup","message":"Deprecated event type for OCP\\IDBConnection::CHECK_MISSING_INDEXES: Symfony\\Component\\EventDispatcher\\GenericEvent is used","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4484.7 Safari/537.36 OPR/78.0.4072.0 (Edition developer)","version":"22.0.0.6","id":"60bcaa5b29de0"}
{"reqId":"ZEPRH9ileZIAeEbemRwj","level":1,"time":"2021-06-06T12:58:20+02:00","remoteAddr":"2a01:c22:a440:6700:a851:5eab:17b1:52ec","user":"Micha","app":"no app in context","method":"GET","url":"/nextcloud/settings/ajax/checksetup","message":"Deprecated event type for OCP\\IDBConnection::CHECK_MISSING_PRIMARY_KEYS: Symfony\\Component\\EventDispatcher\\GenericEvent is used","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4484.7 Safari/537.36 OPR/78.0.4072.0 (Edition developer)","version":"22.0.0.6","id":"60bcaa5b29e8c"}

The three database checks produce a "deprecated event type" log entry, although just as "info". I know it's not a real bug, but I think when a method is already deprecated so that it produces log messages, shouldn't at least the Nextcloud core scripts use the new methods, instead of spamming the logs (and potentially confusing users by this and making debugging for volunteers in the forum more difficult)? Probably this can be done before final NC22 release 🙂.

Server configuration

Operating system: Debian 11 Bullseye

Web server: Apache2

Database: MariaDB

PHP version: 7.4

Nextcloud version: 22.0.0 beta3

Updated from an older Nextcloud/ownCloud or fresh install: Upgraded from... uff it's an old instance, but the same happens on a fresh test install, upgraded from stable NC21 to beta.

Where did you install Nextcloud from:

Signing status:

Signing status ``` all passed ```

List of activated apps:

App list ``` Enabled: - accessibility: 1.7.0 - activity: 2.15.0 - apporder: 0.12.0 - calendar: 2.2.2 - cloud_federation_api: 1.4.0 - contacts: 4.0.0-beta.1 - dashboard: 7.1.0 - dav: 1.18.0 - federatedfilesharing: 1.11.0 - files: 1.16.0 - files_rightclick: 1.1.0 - files_trashbin: 1.11.0 - files_versions: 1.14.0 - impersonate: 1.8.0 - logreader: 2.7.0 - lookup_server_connector: 1.9.0 - notes: 4.0.4 - notifications: 2.10.1 - notify_push: 0.1.7 - oauth2: 1.9.0 - photos: 1.4.0 - previewgenerator: 3.1.1 - provisioning_api: 1.11.0 - ransomware_protection: 1.10.1 - settings: 1.3.0 - spreed: 11.2.2 - survey_client: 1.10.0 - tasks: 0.13.6 - twofactor_backupcodes: 1.10.1 - updatenotification: 1.11.0 - viewer: 1.6.0 - workflowengine: 2.3.0 Disabled: - admin_audit - circles - comments - contactsinteraction - encryption - federation - files_external - files_pdfviewer - files_sharing - files_videoplayer - firstrunwizard - nextcloud_announcements - password_policy - privacy - recommendations - serverinfo - sharebymail - support - systemtags - text - theming - user_ldap - user_status - weather_status ```

Nextcloud configuration:

Config report ``` { "system": { "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "micha.gnoedi.org" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "22.0.0.6", "memcache.local": "\\OC\\Memcache\\APCu", "filelocking.enabled": true, "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 0 }, "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "instanceid": "***REMOVED SENSITIVE VALUE***", "loglevel": 1, "logtimezone": "Europe\/Berlin", "default_phone_region": "DE", "filesystem_check_changes": 0, "hashingThreads": 4, "hashingMemoryCost": 16384, "hashingTimeCost": 3, "trashbin_retention_obligation": "disabled", "versions_retention_obligation": "disabled", "skeletondirectory": "", "maintenance": false, "overwrite.cli.url": "https:\/\/my.domain.org\/nextcloud", "htaccess.RewriteBase": "\/nextcloud", "mail_smtpmode": "smtp", "mail_smtpauthtype": "LOGIN", "mail_smtpsecure": "ssl", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpauth": 1, "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "465", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "theme": "", "knowledgebaseenabled": false, "mysql.utf8mb4": true, "updater.release.channel": "beta", "tempdirectory": "\/mnt\/sda\/ncdata\/tmp", "preview_max_x": 2048, "preview_max_y": 2048, "jpeg_quality": 60, "app_install_overwrite": [ "apporder", "calendar", "impersonate", "ransomware_protection", "contacts", "spreed", "notify_push", "previewgenerator", "tasks" ], "trusted_proxies": "***REMOVED SENSITIVE VALUE***" } } ```

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Opera 78

Operating system: Windows 10

Nextcloud log (data/nextcloud.log)

Nextcloud log ``` {"reqId":"ZEPRH9ileZIAeEbemRwj","level":1,"time":"2021-06-06T12:58:24+02:00","remoteAddr":"2a01:c22:a440:6700:a851:5eab:17b1:52ec","user":"Micha","app":"no app in context","method":"GET","url":"/nextcloud/settings/ajax/checksetup","message":"Deprecated event type for OCP\\IDBConnection::CHECK_MISSING_COLUMNS: Symfony\\Component\\EventDispatcher\\GenericEvent is used","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4484.7 Safari/537.36 OPR/78.0.4072.0 (Edition developer)","version":"22.0.0.6","id":"60bcaa5b29d2f"} {"reqId":"ZEPRH9ileZIAeEbemRwj","level":1,"time":"2021-06-06T12:58:22+02:00","remoteAddr":"2a01:c22:a440:6700:a851:5eab:17b1:52ec","user":"Micha","app":"no app in context","method":"GET","url":"/nextcloud/settings/ajax/checksetup","message":"Deprecated event type for OCP\\IDBConnection::CHECK_MISSING_INDEXES: Symfony\\Component\\EventDispatcher\\GenericEvent is used","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4484.7 Safari/537.36 OPR/78.0.4072.0 (Edition developer)","version":"22.0.0.6","id":"60bcaa5b29de0"} {"reqId":"ZEPRH9ileZIAeEbemRwj","level":1,"time":"2021-06-06T12:58:20+02:00","remoteAddr":"2a01:c22:a440:6700:a851:5eab:17b1:52ec","user":"Micha","app":"no app in context","method":"GET","url":"/nextcloud/settings/ajax/checksetup","message":"Deprecated event type for OCP\\IDBConnection::CHECK_MISSING_PRIMARY_KEYS: Symfony\\Component\\EventDispatcher\\GenericEvent is used","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4484.7 Safari/537.36 OPR/78.0.4072.0 (Edition developer)","version":"22.0.0.6","id":"60bcaa5b29e8c"} ```
MichaIng commented 3 years ago

Oh, I see now that this is reported in #24380 already. However, that issue is about those log types in general, while my aim was to fix the last cases where Nextcloud core is triggering them, at least with the features I'm using.

szaimen commented 3 years ago

Lets track this in https://github.com/nextcloud/server/issues/24380