nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.67k stars 4k forks source link

Support SVG Favicons #28640

Open lzlrd opened 3 years ago

lzlrd commented 3 years ago

How to use GitHub

Is your feature request related to a problem? Please describe. SVG Favicons are supported by a wide variety of browsers. As with the other images supported by the Theming app, it would be preferable to avoid converting SVG images used as favicons and instead leaving them as is.

Describe the solution you'd like SVG Favicons to not be converted and instead used directly.

Describe alternatives you've considered n/a

Additional context Features such as light/dark theme support require SVG images to utilise CSS' prefers-color-scheme feature.

Salvador1313 commented 3 years ago

Спасибо.

Salvador1313 commented 3 years ago

Спасибо

solracsf commented 3 years ago

For reference https://caniuse.com/link-icon-svg

lzlrd commented 3 years ago

For reference https://caniuse.com/link-icon-svg

If support is a concern, there's no harm in generating an favicon.ico and placing it at the root directory which is the recommended method of a fallback (as described by https://html.spec.whatwg.org/multipage/links.html#rel-icon).

skjnldsv commented 1 year ago

https://github.com/nextcloud/server/blob/cf1fae217a1e76bee31f898588957c2900bf7945/apps/theming/lib/ImageManager.php#L329-L332