Wildcard in foldername leads to problems in zip download on Windows

nextcloud / server

☁️ Nextcloud server, a safe home for all your data

https://nextcloud.com

GNU Affero General Public License v3.0

27.4k stars 4.07k forks source link

Wildcard in foldername leads to problems in zip download on Windows #29455

Open neufeind opened 3 years ago

neufeind commented 3 years ago

How to reproduce:

Create a folder that contains a wildcard (*) in the name
Share a folder
Download all contents as ZIP-archive

Works fine on Linux with "ark", able to show contents. Windows ZIP-tool shows the archive as if it was empty.

Workaround:

Replace wildcard in foldername

neufeind commented 3 years ago

Somewhat related to #27891 and #28301

szaimen commented 1 year ago

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

neufeind commented 1 year ago

Retried on 25.0.3. Created a folder "abcdef" and added a simple textfile into that. Shared the folder with creating a link. Opened that link and "download all files", which creates a zip (with the foldername abcdef in it). Windows explorer opens the file for me but shows it is empty. 7zip shows the folder "abc*def" inside the archive but upon extracting turns it into abc_def and extracts the textfile fine.

Should we maybe replace special-characters before creating a zip-file on the server, to avoid problems?