nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.89k stars 4.02k forks source link

Login webflow v3 to support simple signup and global scale #29542

Open AndyScherzinger opened 2 years ago

AndyScherzinger commented 2 years ago

How to use GitHub

Is your feature request related to a problem? Please describe. As briefly discussed with @skjnldsv using login flow v2 is not possible, as the Desktop client does not know to which provider it should connect.

Describe the solution you'd like So we need a "v3" with a gateway

Additionally this needs to be backported to at 23/22/21 since else Apple M1 clients will need to rely on latest server version or 23+ which will likely cause issues in support at some point.

Motivation:

Describe alternatives you've considered none.

Additional context First step is for the files-team to align the API with the clients-team or Tobias and Desktop-dev(s) respectively

szaimen commented 2 years ago

I don't want to intercept here but wouldn't it make more sense to wait for the QT WebEngine to become available for M1 Macs or will that not be available in the foreseen future?

tobiasKaminsky commented 1 year ago

This is no longer only about Desktop, but also will become relevant for other clients, as e.g. v1 starts making trouble on Android nowadays.

marinofaggiana commented 1 year ago

This is no longer only about Desktop, but also will become relevant for other clients, as e.g. v1 starts making trouble on Android nowadays.

Confirm, v1 demonstrates too many problems and limitations, in iOS then with the new limitations for cookies (from different domains) ...

mickenordin commented 10 months ago

I would love to see a webflow v3 land in nextcloud desktop and mobile apps. The fact that mac clients and browser works differently from windows/linux clients is a real head ache. I recently wrote an app that adds back MFA for SSO accounts, and it works nicely in the web and on the desktop client when build with login flow v2 (default on mac, possible at build time on linux/windows), but not on android and the desktop with the webview.

provokateurin commented 9 months ago

I think a new version of the login flow should also implement proper polling. Currently clients have to resend requests until they get a success response. The new version should not close the request until either a timeout (e.g. 30s) occurs or a success response is returned. Something similar is already done in other places like polling for signaling messages with internal signaling for Talk.

tobiasKaminsky commented 8 months ago

:+1: This should be in addition, as I am unsure if e.g. Android can do this.