[Bug]: Adding and removing additional e-mail adress

Valdnet commented 2 years ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

When deleting the secondary email address added first, the edit menu for the second email address is not shown. To delete the second e-mail address you need a page refresh.

Screenshot:

Adding two email addresses:

obraz

Gray inactive menu button for editing the email address added as the second:

obraz

The email address menu is only active after refreshing the page:

obraz

When adding an additional email address, the description "Primary email for password reset and notifications" appears. In my opinion, it is unnecessarily duplicated.

Screenshot:

obraz

Steps to reproduce

Select "Personal info".
Add an additional email address.
Add a second additional email address.
Delete the first additional email address.
Try to delete the second email address.

Expected behavior

While deleting email addresses, every email address editing menu should be active, no matter which one you delete first.
Deletion of duplicate email description "Primary email for password reset and notifications" when adding an additional email address.

@blizzz Can you fix it?

Installation method

Manual installation

Operating system

No response

PHP engine version

PHP 7.3

Web server

No response

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

[ ] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

Accessibility 1.9.0
Activity 2.15.0
Circles 23.0.1
Collaborative tags 1.13.0
Comments 1.13.0
Contacts Interaction 1.4.0
Dashboard 7.3.0
Deleted files 1.13.0
Federation 1.13.0
File sharing 1.15.0
First run wizard 2.12.0
Gestion 2.0.4
Log Reader 2.8.0
Monitoring 1.13.0
Nextcloud announcements 1.12.0
Notes 4.3.0
Notifications 2.11.1
Password policy 1.13.0
PDF viewer 2.4.0
Photos 1.5.0
Privacy 1.7.0
Recommendations 1.2.0
Right click 1.2.0
Share by mail 1.13.0
Support 1.6.0
Text 3.4.0
Theming 1.14.0
Update notification 1.13.0
Usage survey 1.11.0
User status 1.3.1
Versions 1.16.0
Video player 1.12.0
Weather status 1.3.0
Auditing / Logging 1.13.0
Default encryption module 2.11.0
External storage support 1.15.0
LDAP user and group backend 1.13.1

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

blizzz commented 2 years ago

cc @Pytal

Pytal commented 2 years ago

Fixed in https://github.com/nextcloud/server/pull/31345

Pytal commented 2 years ago

Regarding expected behavior

Deletion of duplicate email description "Primary email for password reset and notifications" when adding an additional email address.

I believe this is working as intended @blizzz ?

blizzz commented 2 years ago

Regarding expected behavior

Deletion of duplicate email description "Primary email for password reset and notifications" when adding an additional email address.

I believe this is working as intended @blizzz ?

I think he means the duplication of the label as seen in the screenshot

Pytal commented 2 years ago

I think he means the duplication of the label as seen in the screenshot

Roger, fixed in https://github.com/nextcloud/server/pull/31347

Pytal commented 2 years ago

Reopening pending https://github.com/nextcloud/server/pull/31345

nextcloud / server