[Bug]: Some translations are using the wrong case for Nextcloud

come-nc commented 2 years ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

The case is officially supposed to be Nextcloud and not NextCloud. But several translations are using NextCloud.

Steps to reproduce

grep -Rl NextCloud

apps/provisioning_api/l10n/sk.js
apps/provisioning_api/l10n/sk.json
apps/files_sharing/l10n/ca.js
apps/files_sharing/l10n/ca.json
apps/cloud_federation_api/l10n/sk.js
apps/cloud_federation_api/l10n/sk.json
apps/settings/l10n/nb.js
apps/settings/l10n/sk.js
apps/settings/l10n/nb.json
apps/settings/l10n/sk.json
apps/settings/tests/Controller/AppSettingsControllerTest.php
apps/files_external/l10n/zh_CN.js
apps/files_external/l10n/zh_CN.json
apps/user_ldap/l10n/nl.json
apps/user_ldap/l10n/fr.js
apps/user_ldap/l10n/nl.js
apps/user_ldap/l10n/fr.json
core/l10n/nb.js
core/l10n/lt_LT.js
core/l10n/lt_LT.json
core/l10n/cs.js
core/l10n/sk.js
core/l10n/cs.json
core/l10n/nb.json
core/l10n/sk.json
core/Command/User/AddAppPassword.php
apps-extra/circles/l10n/zh_CN.js
apps-extra/circles/l10n/sk.js
apps-extra/circles/l10n/sk.json
apps-extra/circles/l10n/zh_CN.json
apps-extra/survey_client/l10n/es.json
apps-extra/survey_client/l10n/th.json
apps-extra/survey_client/l10n/th.js
apps-extra/survey_client/l10n/es.js
apps-extra/survey_client/l10n/gl.json
apps-extra/survey_client/l10n/gl.js
apps-extra/firstrunwizard/l10n/sl.js
apps-extra/firstrunwizard/l10n/sl.json
apps-extra/activity/l10n/id.js
apps-extra/activity/l10n/es.json
apps-extra/activity/l10n/es_CO.json
apps-extra/activity/l10n/id.json
apps-extra/activity/l10n/es.js
apps-extra/activity/l10n/es_CO.js
apps-extra/files_rightclick/l10n/da.json
apps-extra/files_rightclick/l10n/da.js
apps-extra/logreader/l10n/ja.js
apps-extra/logreader/l10n/ja.json
lib/l10n/sl.js
lib/l10n/sl.json

Expected behavior

There should be no file matching the wrong case. (Note that in the result I posted some are from applications which are not in this repo)

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

[ ] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

Enabled:
  - activity: 2.17.0
  - circles: 25.0.0-alpha.0
  - cloud_federation_api: 1.8.0
  - comments: 1.15.0
  - contactsinteraction: 1.6.0
  - dashboard: 7.5.0
  - dav: 1.23.0
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.0
  - files_pdfviewer: 2.6.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - files_videoplayer: 1.14.0
  - firstrunwizard: 2.14.0
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - nextcloud_announcements: 1.14.0
  - notifications: 2.13.0
  - oauth2: 1.13.0
  - photos: 1.7.0
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - recommendations: 1.4.0
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - support: 1.8.0
  - survey_client: 1.13.0
  - systemtags: 1.15.0
  - text: 3.6.0
  - theming: 2.0.0
  - twofactor_backupcodes: 1.14.0
  - updatenotification: 1.15.0
  - user_ldap: 1.15.0
  - user_migration: 0.0.1
  - user_status: 1.5.0
  - viewer: 1.9.0
  - weather_status: 1.5.0
  - workflowengine: 2.7.0
Disabled:
  - admin_audit
  - encryption
  - files_external
  - password_policy: 1.14.0
  - testing
  - user_oidc

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

szaimen commented 2 years ago

I think these are simple translation issues and I guess they need to be resolved on transifex so not sure what we can do about this?

come-nc commented 2 years ago

I think these are simple translation issues and I guess they need to be resolved on transifex so not sure what we can do about this?

We can keep track of these issues and make sure all instances are fixed.
We can fix the 2 instances in php files:
- apps/settings/tests/Controller/AppSettingsControllerTest.php
- core/Command/User/AddAppPassword.php

PVince81 commented 2 years ago

in general I think we should never use "Nextcloud" in texts but use the product name because of theming

nextcloud / server