nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.12k stars 4.03k forks source link

FreeBusy shows appointments of deleted calendars #32989

Open brunt82 opened 2 years ago

brunt82 commented 2 years ago

Steps to reproduce

  1. Create a calendar with appointments.
  2. Delete this calendar.
  3. Create a new appointment from another user account with the participant who deleted the calendar and display the free-busy times of him.
  4. The appointments of the deleted calendar will still be displayed in the free-busy view.

Expected behavior

When I delete a calendar (= move it to the trash bin) I would expect, that the free-busy view does not show the deleted appointments anymore.

Actual behaviour

The free-busy times are displayed as the deleted calendar still exists. As soon as I delete the calendar from trash bin, the free-busy views shows the correct times. Sorry, I don't know if it is a client oder server issue (or maybe both).

Calendar app version

3.4.0

CalDAV-clients used

Webclient only

Browser

FF 101.0.1

Client operating system

Win 10

Server operating system

Debian

Web server

Apache

Database engine version

No response

PHP engine version

PHP 7.4

Nextcloud version

24.0.2

Updated from an older installed version or fresh install

Updated from an older version

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

tcitworld commented 2 years ago

We indeed allow to search in deleted calendars as well, that shouldn't be possible.

Adding a check ($this->isDeleted()) before doing the query should do it. https://github.com/nextcloud/server/blob/eb677bf048a2fd821d3397ccf33aa2b566026d7b/apps/dav/lib/CalDAV/Calendar.php#L331

I don't think we ever need to query contents from deleted calendars.

szaimen commented 1 year ago

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

brunt82 commented 1 year ago

I'm sorry, but we don't use free busy in our environment. I found the issue by an accident and wrote an issue... If you don't want to fix it, let it be.

tcitworld commented 1 year ago

Still an issue.

szaimen commented 1 year ago

Which version did you test?

tcitworld commented 1 year ago

master