nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.71k stars 4k forks source link

[Bug]: CalDAV issues collection ticket #33008

Open miaulalala opened 2 years ago

miaulalala commented 2 years ago

⚠️ This issue respects the following points: ⚠️

Bug description

Collecting all bugs that @st3iny and I found when debugging the scheduling:

1) When deleting events from the trashbin a cancelled email is being sent from scheduling 2) When manually cancelling a recurring event, the sent email will be a method="REQUEST" email instead of a method="CANCEL". 3) Something's funky with processing calendar objects from an external client. Could possibly be the ACLs. "Submit my changes anyway" pops up in Thunderbird. 4) Cannot accept recurrences from external client (internal we have not supported that ... yet)

Steps to reproduce

  1. Install Thunderbird
  2. Add Calendar in Thunderbird
  3. Play around with accepting and declining events generated in Nextcloud

Expected behavior

THe correct email method is set Events from trashbin do not generate emails etc

Also, stumbled upon this bug when testing too: https://bugzilla.mozilla.org/show_bug.cgi?id=1406402

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

Configuration report

No response

List of activated Apps

see c.nc.com config for that

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

ChristophWurst commented 2 years ago

When deleting events from the trashbin a cancelled email is being sent from scheduling

What else is expected? If the organizer discards a meeting, the attendees should be notified, shouldn't they? Would you expect this notification earlier, when the event is moved to the trash bin?

miaulalala commented 2 years ago

When deleting events from the trashbin a cancelled email is being sent from scheduling

What else is expected? If the organizer discards a meeting, the attendees should be notified, shouldn't they? Would you expect this notification earlier, when the event is moved to the trash bin?

yeah, that's exactly the issue. There are two emails being sent - one on moving it to the trashbin, one on deleting it completely.

szaimen commented 1 year ago

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

miaulalala commented 1 year ago

@szaimen thanks for the housekeeping but this needs to stay open

szaimen commented 1 year ago

All right! Then lets add the tech debt label

sparagi commented 1 year ago
  1. May now be filed separately as #36051.
  2. May be the same issue as #21220.

These are getting less likely, but in case it helps:

  1. Since you suspect ACLs, a client might want to ask for confirmation in a situation like #5551, where a sharee is attempting to edit a calendar object whose details they cannot see. If you confirmed "Submit my changes anyway", and this were the situation, I would expect the calendar object's description to change to "Busy".
  2. There are 3 similar (to each other) issues related to clients syncing recurring events. They all sound pretty disruptive, though, and they seem to occur only when recurring events have no valid instances. If syncs weren't failing entirely, the issue you saw is more likely to be different from these.
    • 5641

    • 30514

    • 34790