cheneraie
commented
2 years ago The bug is still here after upgrade to 23.0.8.
Open cheneraie opened 2 years ago
cheneraie
commented
2 years ago The bug is still here after upgrade to 23.0.8.
szaimen
commented
1 year ago Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!
My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!
If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+
cheneraie
commented
1 year ago Hi, tanks for your reply.
I'm now on 24.0.9 version and the bug persists.
pbuchholz123
commented
1 year ago Hi, we are running on version 25.0.3 and we are facing the same issue as described above.
I can see my subfolders and files of my smb share using the SMB-Test app but after creating a new file in that smb share i can see the same errors in my log as cheneraie mentioned above. My SMB-Test runs into an TimedOutException and i am unable to open my smb shares anymore. Even the "Click to recheck the configuration" button went from green to red. After a few minutes everything is "normal" again..
pbuchholz123
commented
1 year ago @szaimen We are on version 25.0.4 now and still having trouble with SMB external storages. I can move local files into the share, delete/rename files in the share, create folders as much as i want, but when creating a file my logs gets flooded with this stuff...
Warning | no app in context | OCP\Files\StorageAuthException: Storage unauthorized. / Error | no app in context | Icewind\SMB\Exception\TimedOutException: / Error | webdav | Sabre\DAV\Exception\ServiceUnavailable: Storage with mount id 2 is not available Error | no app in context | OCP\Files\StorageAuthException: Storage unauthorized. /Test/UUU.docx
After that i cannot access any of my shares anymore, but the file was created. What could be the issue here? Cheers
lollo0296
commented
1 year ago Hi @szaimen, this bug is making NC practically unusable for our business. Is there an ETA for the remediation of this bug?
TL;DR I believe mounting SMB shares is a core feature of NC and also essential for our company. Just a smaller group of remote users uses Nextcloud from different devices in order to access the files that are stored within our Windows Fileserver. For this reason using the Sharing function of NC is not an option for us, SMB ist needed so that insiders and remote users can work on the same files.
pbuchholz123
commented
1 year ago Hi @szaimen, any news for us?
Cheers
szaimen
commented
1 year ago I fear I dont have knowledge about this part of the code.
If you are an enterprise customer you can speed things up by creating a ticket at support.nextcloud.com
pbuchholz123
commented
1 year ago Hello @icewind1991,
we can reproduce this "bug" with a fresh installation of NextCloud and with the NextCloud development version (27.0.0-dev) aswell. We tried a different external storage like SFTP and this works perfectly.
If you need further information just tell me. Cheers
lollo0296
commented
1 year ago Hey @icewind1991,
have you already been able to take a look at this Issue?
pbuchholz123
commented
1 year ago Hello @icewind1991
do you have any information for me/us? We still have trouble with SMB-Shares.
Cheers
joshtrichards
commented
1 year ago When trying to get to the bottom of SMB related issues the following details are highly relevant and therefore needed:
smbclient (from Samba)libsmbclient (from Samba)libsmbclient-php if being used (from OS or PECL)smb.confSometimes there are clues on the SMB server side as well in the logs - or with extended logs that can be enabled.
For good measure the following are also useful since sometimes they turn out to be relevant:
The TimeoutException gets triggered from not getting a response after waiting 20*1000ms (20s). In case of @cheneraie (I can't speak to the others which may or may not be the same issue) this suggests the underlying libsmbclient and/or libsmbclient-php is timing out when we ask for some extended attributes for the target file from the SMB server.
I'm particularly suspicious since this is coming from getxattr() which is just a wrapper from smb*_getxattr. There have been incompatibilities and bugs in between the underlying upstream libraries revolving around this attribute. And these libraries are sourced from the installed system not from Nextcloud (though we have wrapper over the top of them so I'm not saying there aren't possibility issues introduced there).
pbuchholz123
commented
1 year ago Hello @joshtrichards,
thanks for your reply. I can provide the following information for you, hope this helps.
Nextcloud: 26.0.3 Nextcloud AIO: 6.2.1
smbclient: 4.18.3 libsmbclient: 4.18.3-r0
We are using for our external storage our fileserver which is a Windows Server 2016.
Our configuration looks like this:
After saving or "rechecking the configuration" it states green everytime. Even with the SMB-Test plugin i can access the server and list files from the remote directory.
It just breaks somehow after we start creating files in that specific share. But then it breaks every share we have configured.
If you need more just let me know. Cheers
pbuchholz123
commented
1 year ago Hey @joshtrichards
do you have any updates for me/us? Were you able to reproduce the issue?
Cheers
joshtrichards
commented
1 year ago No.
Might be worth capturing some more about the SMB transaction from the Windows server-side when reproducing this behavior:
rfx77
commented
1 year ago This issue is still present and reproducable in latest stable 27
pbuchholz123
commented
1 year ago Hey @joshtrichards,
for testing purposes i created a debian virtual machine and configured it as a samba file server. I was able to list the files within the shared folder via the SMB-Test plugin. Furthermore i was able to create a file on that share, i did it exactly the same way i did it on our windows shares. So is this problem related to that we use a Windows Server and not Samba as a file server?
Cheers
lollo0296
commented
1 year ago Hello @joshtrichards,
I am a co-worker of @pbuchholz123. I managed to capture network traffic from our WindowsServer2016 file server while trying to create a new file in the SMB share through the Nextcloud GUI. I used netsh to do it.
The SMB share is \\filejm01.meeth.de\it and I tried to create the file test.txt within the folder SMB_Issue. The absolute path of the file is \\filejm01.meeth.de\it\SMB_Issue\test.txt.
The file is indeed being created at the desired location, but after a short waiting time the previously mentioned error pops up and the share is disabled for 10 minutes.
See .pcapng file attached. Hopefully a big 💡 will light up on your head looking at the packets.
pbuchholz123
commented
12 months ago Hey @joshtrichards
any news for us 👉👈
Cheers
pbuchholz123
commented
11 months ago Anyone?
cheneraie
commented
11 months ago I can only confirm that the bug is still present in Nextcloud 25.0.12. I've just tested it.
Debian 11, php8.1-smbclient
cheneraie
commented
11 months ago I can only confirm that the bug is still present in Nextcloud 25.0.12. I've just tested it.
Debian 11, php8.1-smbclient
I've just tested this by uninstalling php-smbclient. Nextcloud then uses the system's smbclient backend. In this case, the problem no longer appears.
But without the php-smbclient module, performance for samba mounts is much lower.
lollo0296
commented
11 months ago I've just tested this by uninstalling php-smbclient. Nextcloud then uses the system's smbclient backend. In this case, the problem no longer appears.
@cheneraie I guess this certainly narrows down the issue to the package php-smbclient, doesn't it?
It may be worth to do some research about the behavior of php-smbclient when connecting to a Windows Server based SMB-Server.
But with absolutely no knowledge (on my side) about the complicated code infrastructure of Nextcloud (NC-Server, External storage plugin, @icewind1991 's stuff), how to be sure the issue is indeed related to php-smbclient itself and not to the way NC is using it? (e.g. poor exception handling, a call to the wrong function, perhaps due to the lack of a check whether there is Samba or Windows-SMB behind a given share)
@joshtrichards What is your opinion about it? I'm just trying to think about some possible scenarios behind this extremely annoying bug...
cheneraie
commented
11 months ago It may be worth to do some research about the behavior of php-smbclient when connecting to a Windows Server based SMB-Server.
In our case, SMB mounts are performed from a Windows Server 2016 file server.
pbuchholz123
commented
5 months ago Hello,
are there any news/updates?
Cheers
rglowicki
commented
5 months ago Hi, I managed to check what is the reason for this behavior and I slightly modified the @icewind1991 library - I hope he won't be offended by me ;-)
in the directory: /var/lib/docker/volumes/nextcloud_aio_nextcloud/_data/apps/files_external/3rdparty/icewind/smb/src/Native
in the file: NativeState.php
on line 299 find:
$result = @smbclient_write($this->state, $file, $data, $length);
and replace with:
if(strlen($data)) $result = @smbclient_write($this->state, $file, $data, $length);
else return 0;The whole function should look like this:
public function write($file, string $data, string $path, ?int $length = null): int {
/** @var int $result */
if(strlen($data)) $result = @smbclient_write($this->state, $file, $data, $length);
else return 0;
$this->testResult($result, $path);
return $result;
}In my case it helped.
The configuration I use:
I noticed that when creating a new file, the connection to the LDAP server is lost. After entering the server, I found information in the antivirus system logs that there was an attempt to exploit the SMB.CVE-2011-1267 security vulnerability and the connection was blocked. In the nextcloud manual, in the SMB section, there is information that the built-in library "smbclient" and the optional php module "libsmbclient-php" which I had installed are used to connect to shares. Analyzing further, I discovered that when creating a file, the system tries to perform the same action of creating a new empty file twice, which is recognized by the systems as a DoS attack described in the above-mentioned security vulnerability. I found the function that creates a new file in the @icewind1991 library and for testing I commented out the smbclient_write command (the command not only writes to an already open file, but also creates a new file if it does not exist). It helped! - new files were created correctly and an attempt to create them was called only once. But since the command, in addition to creating a new file, can also write to an existing file, it means that the attempt to create a file with content will probably fail. And in fact - no file could be uploaded to the server. Therefore, I added a simple condition that checks whether the "$data" argument has been passed to the function - if it is empty, it skips the execution of this command.
You must remember that this is not an official nextcloud solution and with some updates, the @icewind1991 library will be replaced with the official version, so the changes will no longer work. You can always add a script ;-)
When I have some time, I will try to analyze whether it is a problem of the library itself and write to its author, or maybe how the library is used by the nextcloud backend.
Let me know if it worked for you.
⚠️ This issue respects the following points: ⚠️
Bug description
The attempt to create a file with the "Add file" button in a smb external storage folder causes an error. We get an alert "Unable to create new file from template".
After this, all SMB external storage on the instance are unavalaible ("Storage with mount id ## is not available" or "External storage not available: Storage unauthorized").
The SMB external storage go back after few minutes. And we can see the file was created anyway.
Steps to reproduce
Expected behavior
Just the possibility to create new files without crashing samba mounts.
Installation method
Manual installation
Operating system
Debian/Ubuntu
PHP engine version
PHP 7.4
Web server
Apache (supported)
Database engine version
MySQL
Is this bug present after an update or on a fresh install?
Updated to a major version (ex. 22.2.3 to 23.0.1)
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
List of activated Apps
Nextcloud Signing status
Nextcloud Logs
Additional info
No response