nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.36k stars 4.06k forks source link

[Bug]: Confirm button on password confirmation dialogue not enabled #34217

Closed blizzz closed 2 years ago

blizzz commented 2 years ago

⚠️ This issue respects the following points: ⚠️

Bug description

When trying to do an administrative change on Nextcloud and the password confirmation dialog appears, the "confirm" button is not enabled, thus pressing it does not have any effect. Pressing [ENTER] is a work around.

Screenshot_20220923_124823

Steps to reproduce

  1. Run NC 25 for a bit
  2. Do an action that may require password confirmation (e.g. app handling)
  3. Enter your password
  4. Try to confirm with a click

Expected behavior

The "Confirm" button gets enabled when the input field is not empty.

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

Configuration report

No response

List of activated Apps

- activity: 2.17.0
  - admin_audit: 1.15.0
  - announcementcenter: 6.4.0-beta.1
  - calendar: 4.0.0-alpha.1
  - calendar_resource_management: 0.3.1
  - circles: 25.0.0-alpha.0
  - cloud_federation_api: 1.8.0
  - collectives: 2.0.0-beta1
  - comments: 1.15.0
  - contacts: 5.0.0-alpha.3
  - contactsinteraction: 1.6.0
  - dashboard: 7.5.0
  - dav: 1.24.0
  - deck: 1.8.0-beta.1
  - droneci_fast_lane: 1.0.2
  - end_to_end_encryption: 1.11.0-beta.1
  - external: 4.1.0
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.0
  - files_lock: 24.0.1
  - files_pdfviewer: 2.6.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - files_videoplayer: 1.14.0
  - firstrunwizard: 2.14.0
  - forms: 3.0.0-beta.1
  - groupfolders: 13.0.0-beta.1
  - guests: 2.3.0
  - integration_discourse: 1.0.4
  - integration_github: 1.0.5
  - integration_mastodon: 1.0.3
  - integration_reddit: 1.0.5
  - integration_twitter: 1.0.3
  - integration_zammad: 1.0.4
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - mail: 2.0.0-beta.7
  - nextcloud_announcements: 1.14.0
  - notes: 4.5.1
  - notifications: 2.13.1
  - notify_push: 0.4.0
  - oauth2: 1.13.0
  - password_policy: 1.15.0
  - photos: 1.7.1
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - related_resources: 1.0.0
  - richdocuments: 7.0.0-beta.1
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - spreed: 15.0.0-rc.1
  - support: 1.8.0
  - survey_client: 1.13.0
  - suspicious_login: 4.3.0
  - systemtags: 1.15.0
  - tasks: 0.14.4
  - text: 3.6.0
  - theming: 2.0.0
  - twofactor_backupcodes: 1.14.0
  - twofactor_nextcloud_notification: 3.5.0-beta.1
  - twofactor_totp: 7.0.0
  - twofactor_webauthn: 1.0.0-beta.2
  - updatenotification: 1.15.0
  - user_ldap: 1.15.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - weather_status: 1.5.0
  - workflowengine: 2.7.0
  - zammad_organisation_management: 1.1.3

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

PVince81 commented 2 years ago

maybe @Pytal can help as he worked on that dialog recently, following focus trap issues with the new modals

Pytal commented 2 years ago

Fixed in https://github.com/nextcloud/nextcloud-password-confirmation/pull/401

Pytal commented 2 years ago

If urgent then we can merge https://github.com/nextcloud/nextcloud-password-confirmation/pull/402

And an admin can make a release as documented https://github.com/nextcloud/nextcloud-password-confirmation#releasing

nickvergessen commented 2 years ago

This is still not updated on server, right?

nickvergessen commented 2 years ago

https://github.com/nextcloud/server/blob/master/package.json#L44

PVince81 commented 2 years ago

@Pytal please update