search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.77k stars 4k forks source link

Checkbox for «Remember password» is broken #3454

Closed Grawl closed 7 years ago

Grawl commented 7 years ago

Steps to reproduce

  1. Open login screen
  2. Fill username and password
  3. Press a checkbox under login button

Expected behaviour

Checkbox changed to checked state.

Actual behaviour

Username and password are sent to server, I logged in without remembered session. Next time I want to use Nextcloud I have to login again.

If I click this checkbox before I fill password, it change own status. If I fill password, it works like login button.

Server configuration

Your demo page.

Client configuration

Browser: latest stable Safari, latest stable Chrome

Operating system: latest stable macOS

LukasReschke commented 7 years ago

I cannot really reproduce your issue here. Could you post a step by step comparison between expected behaviour and actual behaviour? Thanks a lot! :)

Grawl commented 7 years ago

@LukasReschke did you tried to toggle that checkbox after typing a password?

https://vimeo.com/203940256

MorrisJobke commented 7 years ago

cc @ChristophWurst

ChristophWurst commented 7 years ago

Cannot reproduce either. Wen I click the checkbox, the correct form data is sent to the server: bildschirmfoto von 2017-03-06 11-21-43

Test on our demo page.

Grawl commented 7 years ago

@ChristophWurst so you think submitting the form with checkbox is ok?

MorrisJobke commented 7 years ago

@ChristophWurst so you think submitting the form with checkbox is ok?

Yes, because in nearly all cases you will click login after ticking it anyway. cc @jancborchardt

jancborchardt commented 7 years ago

@Grawl yes, this is intended behavior. If you put in your username, and password, and then check »stay logged in«, your next click will be the log in button anyway.

Closing hence. :)

jancborchardt commented 7 years ago

@Grawl and I just saw on your profile you are a designer – you are very welcome to get involved in Nextcloud development! :) Just check out some of our design issues at https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3Adesign

Grawl commented 7 years ago

your next click will be the log in button anyway.

okay I got it. clever idea of UX improvement but it's not clear that checkbox is checked and button is pressed. it's unexpected behaviour, and we have to make it so: show checkbox animation and show button click/hover/active animation, so user of login page will be sure that all is ok.

you are very welcome to get involved in Nextcloud development!

let's start from this issue, and then I will ask you an other my questions about Nextcloud.