nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.27k stars 3.96k forks source link

Dont use SVG Images in Mails #34833

Open ThomasCr opened 1 year ago

ThomasCr commented 1 year ago

⚠️ This issue respects the following points: ⚠️

Bug description

I got today a Mail, that a new plugin version is availible. Our Outlook Client doest Displays the image, so I went to the source to find the problem.

grafik

It is the following part: <img src="https://cloud.mydomain.de/apps/updatenotification/img/notification.svg" alt="•">

The image is availible at this place, but most eMail Clients dont support SVG Images.

Other related reports https://github.com/nextcloud/server/issues/4647

Steps to reproduce

  1. wait for the mail and inspect

Expected behavior

The Image should be in a supported format.

Installation method

Community Docker image

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Configuration report

{
    "system": {
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "overwriteprotocol": "https",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "mail_smtpsecure": "",
        "mail_smtpauth": false,
        "mail_smtpauthtype": "PLAIN",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "cloud.mydomain.de",
            "XXX.XXX.XXX.XXX"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "24.0.6.1",
        "overwrite.cli.url": "https:\/\/cloud.mydomain.de\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "default_language": "de",
        "default_locale": "de_DE",
        "default_phone_region": "DE",
        "trashbin_retention_obligation": "auto",
        "versions_retention_obligation": "auto",
        "skeletondirectory": "\/var\/www\/html\/data\/__KliWoSkeleton",
        "twofactor_enforced": "true",
        "0": "twofactor_enforced_groups",
        "twofactor_enforced_excluded_groups": [
            "admin"
        ],
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "twofactor_enforced_groups": [
            "everyone"
        ],
        "loglevel": 2,
        "maintenance": false,
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "password": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "proxy": "10.100.0.2:3128"
    }
}

List of activated Apps

Enabled:
  - accessibility: 1.10.0
  - activity: 2.16.0
  - admin_audit: 1.14.0
  - checksum: 1.1.4
  - circles: 24.0.1
  - cloud_federation_api: 1.7.0
  - comments: 1.14.0
  - contactsinteraction: 1.5.0
  - dav: 1.22.0
  - federatedfilesharing: 1.14.0
  - files: 1.19.0
  - files_accesscontrol: 1.14.1
  - files_automatedtagging: 1.14.0
  - files_markdown: 2.3.6
  - files_pdfviewer: 2.5.0
  - files_retention: 1.13.2
  - files_rightclick: 1.3.0
  - files_sharing: 1.16.2
  - files_trashbin: 1.14.0
  - files_versions: 1.17.0
  - files_videoplayer: 1.13.0
  - group_everyone: 0.1.10
  - groupfolders: 12.0.2
  - logreader: 2.9.0
  - lookup_server_connector: 1.12.0
  - notifications: 2.12.1
  - oauth2: 1.12.0
  - password_policy: 1.14.0
  - photos: 1.6.0
  - privacy: 1.8.0
  - provisioning_api: 1.14.0
  - recommendations: 1.3.0
  - serverinfo: 1.14.0
  - settings: 1.6.0
  - sharebymail: 1.14.0
  - support: 1.7.0
  - systemtags: 1.14.0
  - text: 3.5.1
  - theming: 1.15.0
  - twofactor_backupcodes: 1.13.0
  - twofactor_email: 2.7.1
  - twofactor_totp: 6.4.1
  - twofactor_webauthn: 0.3.3
  - updatenotification: 1.14.0
  - user_ldap: 1.14.1
  - user_retention: 1.7.0
  - viewer: 1.8.0
  - weather_status: 1.4.0
  - workflowengine: 2.6.0
Disabled:
  - dashboard: 7.2.0
  - encryption
  - federation: 1.12.0
  - files_external
  - firstrunwizard: 2.11.0
  - nextcloud_announcements: 1.11.0
  - survey_client: 1.10.0
  - user_status: 1.2.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

No response

szaimen commented 1 year ago

This rather sounds like a feature request

joshtrichards commented 10 months ago

Ref: https://www.caniemail.com/features/image-svg/

jacobseated commented 10 months ago

This probably is just the .svg being incompatible with gmail, because I don't think quoted printable has any influence on this (I noticed the URL seemed broken up with "=" in the gmail source).

I know some e-mail clients have ridiculous low line length limits, which can cause various issues when the lines are split up. It does not seem to be the case here though.

Whatever the cause, there has to be a template somewhere so we can fix this. It looks broken to other users, and also, any potential images used in e-mail are of course best base64 encoded and embedded directly. No idea why such a tiny symbol is hot linked. The .svg does not even seem to be requested in gmail. But, Hot-linking is moronic for e-mail anyway imo.

I have to check properly after work as to how to fix it.