nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.91k stars 4.02k forks source link

Error message when trying push item to calendar that does not have the component enabled isn't verbose enough #35036

Closed Thaodan closed 1 year ago

Thaodan commented 1 year ago

Steps to reproduce

  1. Create a new calendar
  2. Add the calendar to your favorite app
  3. Add a new item to the calendar that is using a component that isn't enabled by default such as vtodo or vjournal.
  4. See error

Expected behavior

The nextcloud log should contain an exception about pushing an item is using a component that isn't enabled in this calendar.

Actual behaviour

The nextcloud log contains message such as:


<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\CalDAV\Exception\InvalidComponentType</s:exception>
  <s:message>iCalendar objects must at least have a component of type VEVENT</s:message>
  <cal:supported-calendar-component xmlns:cal="urn:ietf:params:xml:ns:caldav"/>
</d:error>

Calendar app version

3.5.0-1

CalDAV-clients used

KDE-PIM/Kontact, Org-Caldav, SailfishOS

Browser

Not relevant

Client operating system

No response

Server operating system

No response

Web server

Nginx

Database engine version

PostgreSQL

PHP engine version

PHP 8.1

Nextcloud version

24.0.4

Updated from an older installed version or fresh install

Updated from an older version

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

ChristophWurst commented 1 year ago

The nextcloud log should contain an exception

This is not an application error, it's a forbidden operation done by one of the users. A Nextcloud admin can not do anything about this.

If we add logging then it should be debug or info level. The change would go into https://github.com/nextcloud/server/tree/master/apps/dav, where the Nextcloud DAV backend is located.

Thaodan commented 1 year ago

The nextcloud log should contain an exception

This is not an application error, it's a forbidden operation done by one of the users. A Nextcloud admin can not do anything about this.

If we add logging then it should be debug or info level. The change would go into https://github.com/nextcloud/server/tree/master/apps/dav, where the Nextcloud DAV backend is located.

The backend components shows this an error to overwrite the message from Sabredav it should be the same level I think.

Ok can you transfer the issue to other repository?

szaimen commented 1 year ago

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

nextcloud-command commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

Thaodan commented 1 year ago

I will look again into this in ca a week.