nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.44k stars 4.08k forks source link

downloadURL- why absolute link #35942

Open dariodsa opened 1 year ago

dariodsa commented 1 year ago

Is your feature request related to a problem? Please describe. If you expose your Nextcloud over multiple networks (in-house network (one dns), internet access (different dns)) then downloading won't work (download files shared over direct link). Nextcloud is only aware of the in-house name, but he isn't aware of the internet-access dns and for them he renders the in-house address. That link is not accessible from the internet and download fails.

Describe the solution you'd like Relative links for direct downloading files.

Additional context https://github.com/nextcloud/server/blob/8f7996fb1bc08ba9845435c79808b02d5927d369/apps/files_sharing/lib/Controller/ShareController.php#L464-L467

rekcodocker commented 1 year ago

Observation: It works for me; I use the external name always. Even internally. So there is no distinction between internal and external, everything is accessed by the external name.

This ensures clients work whether they are on the local network or roaming. And yes, the traffic makes a bit of a detour. I don't know exactly how far but I suppose it goes to the router on my network, recognizes the IP address and routes it back in.

I speed things up by a local DNS resolution: The external name points directly to the internal server.

szaimen commented 1 year ago

Observation: It works for me; I use the external name always. Even internally. So there is no distinction between internal and external, everything is accessed by the external name.

This ensures clients work whether they are on the local network or roaming. And yes, the traffic makes a bit of a detour. I don't know exactly how far but I suppose it goes to the router on my network, recognizes the IP address and routes it back in.

I speed things up by a local DNS resolution: The external name points directly to the internal server.

Yes, this is how it is supposed to work.

dariodsa commented 1 year ago

Those are all workarounds. I don't see any reason why this couldn't be changed to relative link?