nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.25k stars 4.05k forks source link

Remove misleading output when running `occ upgrade` #36289

Open te-online opened 1 year ago

te-online commented 1 year ago

How to use GitHub

Is your feature request related to a problem? Please describe. When I run occ upgrade the following output is produced:

Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade

Then Nextcloud continues to run the upgrade as expected:

Setting log level to debug
Updating database schema
Updated database
Starting code integrity check...
Finished code integrity check
Update successful

Describe the solution you'd like I think the first 2 lines of output should be removed.

In my opinion it's misleading to state "You may user your browser or the occ upgrade command" while I'm already using the "occ upgrade command" and the upgrade is in fact running.

I experience this especially when updating a nextcloud docker image as the image will run upgrade on startup automatically. Every time I inspect the logs I wonder if I need to run occ upgrade manually now or if it's already running, since the next output can take a while to show up and it often lead me to believe I need to run occ upgrade now, causing it to be run twice.

Describe alternatives you've considered The message seems to add no value, as the user is actively performing the upgrade operation – it should be clear to the user already that an upgrade is being performed on their request.

At this time, I think the simplest solution is to remove the output.

Additional context There are at least 2 related issues, which would benefit from removing the output:

joshtrichards commented 4 weeks ago

Related: