nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.38k stars 4.07k forks source link

Email about activity for multiple events has no plural form for german #36309

Open rakekniven opened 1 year ago

rakekniven commented 1 year ago

Steps to reproduce

  1. Create multiple events in one day
  2. See activity in email notification

2023-01-18_08h16_47 Should be Person1 hat die Termine ... (btw. and should be und.

Bildschirm­foto 2023-01-12 um 12 33 00

Should be Sie haben die Termine ...

Expected behavior

There should be a plural form if notification contains more than one event. See my comments above below the screenshots.

Actual behaviour

The notification wording is suitable for mentioning changes for ONE event, not multiple.

Calendar app version

4.2.1

CalDAV-clients used

No response

Browser

ff 108

Client operating system

macOS, windows

Server operating system

Ubuntu 22.04 LTS

Web server

Apache

Database engine version

PostgreSQL

PHP engine version

PHP 8.1

Nextcloud version

25.0.2

Updated from an older installed version or fresh install

Updated from an older version

rakekniven commented 1 year ago

I checked Transifex already and could not find out where the "and/und" comes from. Maybe someone can point me to the related source code?

rakekniven commented 1 year ago

This issue should be valid for other languages as well.

rakekniven commented 1 year ago

Not sure if I used the correct repo after looking into Tx/code again.

For singular I found :

https://github.com/nextcloud/server/blob/5e3a3c0c8faa45489aa6ac610728b4177501c198/apps/dav/lib/CalDAV/Activity/Provider/Event.php#L140

But where is the magic for chaining events together for the message?

miaulalala commented 1 year ago

It's here: https://github.com/nextcloud/server/blob/5e3a3c0c8faa45489aa6ac610728b4177501c198/lib/private/Activity/EventMerger.php#L200

rakekniven commented 1 year ago

Hello @miaulalala , thanks for your support. Now it gets curious. The strings on Transifex were translated correctly 6 years ago. If you look at my screen shot from the email, it says "and". Is there any other code used here for the email?

rakekniven commented 1 year ago

btw. can you shift my issue to the server repo?