[Bug]: Star component in sidebar behaves erratically when using the photo viewer

jsmtux commented 2 years ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] Nextcloud Server is running on 64bit capable CPU, PHP and OS.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

When in the Files or in the Gallery app, which use the same sidebar component, clicking the star icon in the sidebar to add a file/photo to the favorites and then changing to a different item breaks the "starred" information for the following files.

When the bug is present, the next image will also show as starred even if it is not. All the following shown files will be seen as "starred" even if they are not. By closing the sidebar or going over a "really starred" file, the issue will momentarily disappear.

This is not only an inconvenience because the wrong things are shown, but also because it makes it confusing to actually set another file as favorite.

Steps to reproduce

Navigate to a folder with several images where none is "starred"
Open an image so that it shows over the rest of the UI
Reveal the sidebar
Click on the star for the current image
Navigate to the next image by using the arrow positioned at the right of the image
Observer the "starred" status of the new image

Expected behavior

After starring a file and then moving to another, if the following one is not part of the favorites, the star should go back to being grey.

Installation method

Official Docker image

Operating system

Other

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

[X] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

Enabled:
  - cloud_federation_api: 1.8.0
  - comments: 1.15.0
  - contactsinteraction: 1.6.0
  - dashboard: 7.5.0
  - dav: 1.24.0
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - lookup_server_connector: 1.13.0
  - oauth2: 1.13.0
  - photos: 1.7.0
  - provisioning_api: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - systemtags: 1.15.0
  - theming: 2.0.0
  - twofactor_backupcodes: 1.14.0
  - updatenotification: 1.15.0
  - user_status: 1.5.0
  - viewer: true
  - weather_status: 1.5.0
  - workflowengine: 2.7.0
Disabled:
  - admin_audit
  - bruteforcesettings
  - encryption
  - files_external
  - testing
  - user_ldap

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

szaimen commented 1 year ago

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

jsmtux commented 1 year ago

Hi, I am now running 25.0.1 and I can still reproduce the issue. Thanks for your work! Let me know if you explicitly need 25.0.3 and I'll try updating this week.

szaimen commented 1 year ago

Yes, 25.0.3 would be good. Thanks!

jsmtux commented 1 year ago

Hi @szaimen , just updated to 25.0.3 and the issue persists as described.

skjnldsv commented 1 year ago

@szaimen why is it viewer? It's related to the sidebar?

szaimen commented 1 year ago

Ah I thought this was only happening when the sidebar of the viewer gets used. So is it actually the vue component?

skjnldsv commented 1 year ago

Most likely there is no global event fired between the multiple front areas (legacy/vue conflict) so the sidebar is unaware of what is happening in files and vice-versa.

The viewer doesn't use the Sidebar component. It just call the Files sidebar from viewer :)

szaimen commented 1 year ago

Ah so it actually is a server issue?

skjnldsv commented 1 year ago

I think so :)

szaimen commented 1 year ago

Okay

nextcloud / server