search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.78k stars 4k forks source link

[Bug]: Design/Theming: Uploaded logo not shown on Login page (on a NEW 26.0.0beta2 install) #36540

Closed nursoda closed 1 year ago

nursoda commented 1 year ago

⚠️ This issue respects the following points: ⚠️

Bug description

Neither default nor custom logo is not shown on the login page.

Steps to reproduce

  1. Install a new NC 26.0.0beta2 instance
  2. check out the mini login page preview on /settings/admin/theming: Nextcloud logo is shown
  3. Open login page and verify that the nextcloud logo is not shown but only the login dialog itself
  4. This doesn't change if one uploads an SVG or PNG logo in /settings/admin/theming

Expected behavior

Default and uploaded logos should be shown on login page. If it was abandoned in NC26, then /settings/admin/theming must be reworked. If not, then this is a regression since that used to work in NC 25.

Installation method

Community Manual installation with Archive

Operating system

Other

PHP engine version

PHP 8.1

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "stage.selbstbestimmt-digital.de"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "26.0.0.4",
        "overwrite.cli.url": "https:\/\/stage.selbstbestimmt-digital.de",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "updater.release.channel": "beta",
        "installed": true,
        "app_install_overwrite": [
            "twofactor_webauthn"
        ]
    }
}

List of activated Apps

Enabled:
  - cloud_federation_api: 1.9.0
  - dav: 1.25.0
  - federatedfilesharing: 1.16.0
  - files: 1.21.1
  - files_rightclick: 1.5.0
  - files_sharing: 1.18.0
  - files_trashbin: 1.16.0
  - logreader: 2.11.0
  - lookup_server_connector: 1.14.0
  - notifications: 2.14.0
  - oauth2: 1.14.0
  - password_policy: 1.16.0
  - provisioning_api: 1.16.0
  - serverinfo: 1.16.0
  - settings: 1.8.0
  - sharebymail: 1.16.0
  - text: 3.7.0
  - theming: 2.1.1
  - twofactor_backupcodes: 1.15.0
  - twofactor_webauthn: 1.0.0
  - updatenotification: 1.16.0
  - viewer: 1.10.0
  - workflowengine: 2.8.0
Disabled:
  - activity: 2.18.0 (installed 2.18.0)
  - admin_audit: 1.16.0
  - bruteforcesettings: 2.6.0
  - circles: 26.0.0-beta2 (installed 26.0.0-beta2)
  - comments: 1.16.0 (installed 1.16.0)
  - contactsinteraction: 1.7.0 (installed 1.7.0)
  - dashboard: 7.6.0 (installed 7.6.0)
  - encryption: 2.14.0
  - federation: 1.16.0 (installed 1.16.0)
  - files_external: 1.18.0
  - files_pdfviewer: 2.7.0 (installed 2.7.0)
  - files_versions: 1.19.1 (installed 1.19.1)
  - firstrunwizard: 2.15.0 (installed 2.15.0)
  - nextcloud_announcements: 1.15.0 (installed 1.15.0)
  - photos: 2.2.0 (installed 2.2.0)
  - privacy: 1.10.0 (installed 1.10.0)
  - recommendations: 1.5.0 (installed 1.5.0)
  - related_resources: 1.1.0-alpha1 (installed 1.1.0-alpha1)
  - support: 1.9.0 (installed 1.9.0)
  - survey_client: 1.14.0 (installed 1.14.0)
  - suspicious_login: 4.4.0
  - systemtags: 1.16.0 (installed 1.16.0)
  - twofactor_totp: 8.0.0-alpha.0
  - user_ldap: 1.16.0
  - user_status: 1.6.0 (installed 1.6.0)
  - weather_status: 1.6.0 (installed 1.6.0)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

{
  "reqId": "IVoJQawUURPQO3ObZ0BZ",
  "level": 3,
  "time": "2023-02-05T00:49:36+00:00",
  "remoteAddr": "IP-ADDRESS",
  "user": "USERNAME",
  "app": "index",
  "method": "GET",
  "url": "/apps/theming/icon?v=814abd72",
  "message": "Could not get appdata folder for theming",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "26.0.0.4",
  "exception": {
    "Exception": "RuntimeException",
    "Message": "Could not get appdata folder for theming",
    "Code": 0,
    "Trace": [
      {
        "file": "/FOLDER/lib/private/Files/AppData/AppData.php",
        "line": 147,
        "function": "getAppDataFolder",
        "class": "OC\\Files\\AppData\\AppData",
        "type": "->"
      },
      {
        "file": "/FOLDER/apps/theming/lib/ImageManager.php",
        "line": 336,
        "function": "newFolder",
        "class": "OC\\Files\\AppData\\AppData",
        "type": "->"
      },
      {
        "file": "/FOLDER/apps/theming/lib/ImageManager.php",
        "line": 118,
        "function": "getRootFolder",
        "class": "OCA\\Theming\\ImageManager",
        "type": "->"
      },
      {
        "file": "/FOLDER/apps/theming/lib/Controller/IconController.php",
        "line": 155,
        "function": "getImage",
        "class": "OCA\\Theming\\ImageManager",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 230,
        "function": "getTouchIcon",
        "class": "OCA\\Theming\\Controller\\IconController",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 137,
        "function": "executeController",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/AppFramework/App.php",
        "line": 171,
        "function": "dispatch",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/Route/Router.php",
        "line": 298,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::"
      },
      {
        "file": "/FOLDER/lib/base.php",
        "line": 1050,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "/FOLDER/index.php",
        "line": 36,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "/FOLDER/lib/private/Files/AppData/AppData.php",
    "Line": 108,
    "CustomMessage": "--"
  }
}
{
  "reqId": "IVoJQawUURPQO3ObZ0BZ",
  "level": 3,
  "time": "2023-02-05T00:49:36+00:00",
  "remoteAddr": "IP-ADDRESS",
  "user": "USERNAME",
  "app": "cssresourceloader",
  "method": "GET",
  "url": "/apps/theming/icon?v=814abd72",
  "message": "Could not find resource core/css/styles.css to load",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "26.0.0.4",
  "data": {
    "app": "cssresourceloader"
  }
}
{
  "reqId": "IVoJQawUURPQO3ObZ0BZ",
  "level": 3,
  "time": "2023-02-05T00:49:36+00:00",
  "remoteAddr": "IP-ADDRESS",
  "user": "USERNAME",
  "app": "cssresourceloader",
  "method": "GET",
  "url": "/apps/theming/icon?v=814abd72",
  "message": "Could not find resource core/css/header.css to load",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "26.0.0.4",
  "data": {
    "app": "cssresourceloader"
  }
}
{
  "reqId": "ClDDTJH1w3u2xRDQOQf2",
  "level": 3,
  "time": "2023-02-05T00:50:02+00:00",
  "remoteAddr": "IP-ADDRESS",
  "user": "USERNAME",
  "app": "index",
  "method": "GET",
  "url": "/core/preview?fileId=25&x=250&y=250",
  "message": "Could not get appdata folder for preview",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "26.0.0.4",
  "exception": {
    "Exception": "RuntimeException",
    "Message": "Could not get appdata folder for preview",
    "Code": 0,
    "Trace": [
      {
        "file": "/FOLDER/lib/private/Files/AppData/AppData.php",
        "line": 147,
        "function": "getAppDataFolder",
        "class": "OC\\Files\\AppData\\AppData",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/Preview/Storage/Root.php",
        "line": 74,
        "function": "newFolder",
        "class": "OC\\Files\\AppData\\AppData",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/Preview/Generator.php",
        "line": 685,
        "function": "newFolder",
        "class": "OC\\Preview\\Storage\\Root",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/Preview/Generator.php",
        "line": 139,
        "function": "getPreviewFolder",
        "class": "OC\\Preview\\Generator",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/Preview/Generator.php",
        "line": 116,
        "function": "generatePreviews",
        "class": "OC\\Preview\\Generator",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/PreviewManager.php",
        "line": 188,
        "function": "getPreview",
        "class": "OC\\Preview\\Generator",
        "type": "->"
      },
      {
        "file": "/FOLDER/core/Controller/PreviewController.php",
        "line": 144,
        "function": "getPreview",
        "class": "OC\\PreviewManager",
        "type": "->"
      },
      {
        "file": "/FOLDER/core/Controller/PreviewController.php",
        "line": 113,
        "function": "fetchPreview",
        "class": "OC\\Core\\Controller\\PreviewController",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 230,
        "function": "getPreviewByFileId",
        "class": "OC\\Core\\Controller\\PreviewController",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 137,
        "function": "executeController",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/AppFramework/App.php",
        "line": 171,
        "function": "dispatch",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->"
      },
      {
        "file": "/FOLDER/lib/private/Route/Router.php",
        "line": 298,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::"
      },
      {
        "file": "/FOLDER/lib/base.php",
        "line": 1050,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "/FOLDER/index.php",
        "line": 36,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "/FOLDER/lib/private/Files/AppData/AppData.php",
    "Line": 108,
    "CustomMessage": "--"
  }
}
{
  "reqId": "ClDDTJH1w3u2xRDQOQf2",
  "level": 3,
  "time": "2023-02-05T00:50:02+00:00",
  "remoteAddr": "IP-ADDRESS",
  "user": "USERNAME",
  "app": "cssresourceloader",
  "method": "GET",
  "url": "/core/preview?fileId=25&x=250&y=250",
  "message": "Could not find resource core/css/styles.css to load",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "26.0.0.4",
  "data": {
    "app": "cssresourceloader"
  }
}
{
  "reqId": "ClDDTJH1w3u2xRDQOQf2",
  "level": 3,
  "time": "2023-02-05T00:50:02+00:00",
  "remoteAddr": "IP-ADDRESS",
  "user": "USERNAME",
  "app": "cssresourceloader",
  "method": "GET",
  "url": "/core/preview?fileId=25&x=250&y=250",
  "message": "Could not find resource core/css/header.css to load",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "26.0.0.4",
  "data": {
    "app": "cssresourceloader"
  }
}

Additional info

No response

szaimen commented 1 year ago

Cc @Pytal @JuliaKirschenheuter

JuliaKirschenheuter commented 1 year ago

Thought that was already reverted by https://github.com/nextcloud/server/pull/35071#issuecomment-1385441275 I will have a look

szaimen commented 1 year ago

Omly reverted in stable25 and not in master iirc... And thanks!

JuliaKirschenheuter commented 1 year ago

Omly reverted in stable25 and not in master iirc... And thanks!

Not sure, what is about this: https://github.com/nextcloud/server/commit/9af7ee8d11b43a7a3d14f7aa8390aff0a4174f55

szaimen commented 1 year ago

Ah right. Then another commit might have broken it? Do you know more @skjnldsv ?

szaimen commented 1 year ago

Also cc @nextcloud/server-frontend

skjnldsv commented 1 year ago

https://github.com/nextcloud/server/pull/36930