Open szaimen opened 1 year ago
also cc @nextcloud/ios
Seems to work just fine with an svg and the mask for safari:
Now we'd need to check if there is a way to invert the svg to be filled with masking out the app icon or if the new safari icon design would be fine, but otherwise I'd say it would be a good step to get rid of imagick there.
Would also solve https://github.com/nextcloud/server/issues/27502
Great 🎉
Maybe someone with a mac could look into this for 27? :)
I could help testing a PR on other platforms :)
Also cc @AndyScherzinger
I am not having a mac, so If it works for Julius I think we are fine.
Also cc @nextcloud/server
Any chances to see this landing in v28?
It was not prioritized so unfortunately no. But cc @sorbaugh and @AndyScherzinger
What @szaimen said. So given our priorities for v28 we won't have the capacity. However if somebody would be willing to contribute an implementation than we are more than happy to review'n'merge it.
This allows us to get rid of using imagick in iconbuilder of the theming app, which in return allows us to not enforce this requirement anymore since gd and imaginary can be used for all other tasks.
Julius found this: https://www.leereamsnyder.com/blog/favicons-in-2021#safari-does-not-fully-support-svg-icons
cc @juliushaertl